From owner-freebsd-x11@FreeBSD.ORG  Sat Sep  7 21:13:07 2013
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
Delivered-To: freebsd-x11@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id AF89982A
 for <freebsd-x11@freebsd.org>; Sat,  7 Sep 2013 21:13:07 +0000 (UTC)
 (envelope-from jan.kokemueller@gmail.com)
Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com
 [IPv6:2607:f8b0:4003:c01::232])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7DC7025A6
 for <freebsd-x11@freebsd.org>; Sat,  7 Sep 2013 21:13:07 +0000 (UTC)
Received: by mail-ob0-f178.google.com with SMTP id ef5so4775419obb.37
 for <freebsd-x11@freebsd.org>; Sat, 07 Sep 2013 14:13:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:date:message-id:subject:from:to:content-type;
 bh=MLpFLd2EwUebtH/qyb+mOOulxxrioYPMKlCN/eQ5GsM=;
 b=DP/W9OzlgSGkOWID3n8NS4usFv5yV1m8u8NfV53odJWUXYy39ftkuo8GTYm1e+Dmjk
 IVMw5iA63Su8oEV38HA4lBLYwshN3TmgFLMewr7BWYbIWPZf1E8jz1rNTp0QwEzMA55p
 QhgifT/e+beE8tQB8cnMMgCOmJOKkBlL7cjHatLcHj2mfzkAJxtH4m9VyvyGv8ZNsj9N
 WEGw/H3nqmJfYCycrZ2QabgEhLVjZznK6FuPdJzzDfLvrlvIs6QOkFlQ6lMCxstIjgwa
 3UtTReAAJbGb8BBIY5WNyEoVB8kwcwWqLWf1sGAo+mc2h10TeFh3VjyEN5wF46Ip5Rux
 jjWA==
MIME-Version: 1.0
X-Received: by 10.60.118.4 with SMTP id ki4mr6533753oeb.22.1378588386803; Sat,
 07 Sep 2013 14:13:06 -0700 (PDT)
Received: by 10.182.29.106 with HTTP; Sat, 7 Sep 2013 14:13:06 -0700 (PDT)
Date: Sat, 7 Sep 2013 23:13:06 +0200
Message-ID: <CAMog33q-9u-72dE9rQJ_PJA9WYKd6SCv8+NKjMRHbpfYjCKFMA@mail.gmail.com>
Subject: Kernel ABI problem after recent Synaptics changes in psm(4) (?)
From: =?ISO-8859-1?Q?Jan_Kokem=FCller?= <jan.kokemueller@gmail.com>
To: freebsd-x11@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
 <mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Sep 2013 21:13:07 -0000

The recent psm commit finally fixed the right touchpad button on my laptop.
Thanks to all involved! :)
I was curious about the "ABI problem" with the old patch and did a quick
test:
When I compile this program against the old sys/mouse.h and run it with a
new kernel (>= r255154) I get an error: "ioctl: Inappropriate ioctl for
device". It works fine when mouse.h and the kernel are in sync. I wonder if
the synapticshw struct can be changed at all without breaking the
MOUSE_SYN_GETHWINFO ioctl?


#include <stdio.h>
#include <stdlib.h>

#include <fcntl.h>
#include <sys/mouse.h>

int main() {
    int psm_fd = open("/dev/psm0", O_RDONLY);
    if (psm_fd == -1) {
        perror("open");
        return EXIT_FAILURE;
    }

    synapticshw_t synhw;
    if (ioctl(psm_fd, MOUSE_SYN_GETHWINFO, &synhw) == -1) {
        perror("ioctl");
        return EXIT_FAILURE;
    }

    printf("synaptics version: %d.%d\n", synhw.infoMajor, synhw.infoMinor);

    return EXIT_SUCCESS;
}