Date: Tue, 8 May 2012 04:01:19 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235129 - head/tools/tools/zfsboottest Message-ID: <20120508020119.GE1395@garage.freebsd.pl> In-Reply-To: <201205071503.q47F3gsa070124@svn.freebsd.org> References: <201205071503.q47F3gsa070124@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Y1L3PTX8QE8cb2T+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 07, 2012 at 03:03:42PM +0000, Andriy Gapon wrote: > Author: avg > Date: Mon May 7 15:03:42 2012 > New Revision: 235129 > URL: http://svn.freebsd.org/changeset/base/235129 >=20 > Log: > zfsboottest.sh: gracefully handle default value of bootfs property I'd prefer if people avoid having their root file system at the pool level, so maybe we could leave it as a warning? > Reported by: theraven > MFC after: 10 days >=20 > Modified: > head/tools/tools/zfsboottest/zfsboottest.sh >=20 > Modified: head/tools/tools/zfsboottest/zfsboottest.sh > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/tools/tools/zfsboottest/zfsboottest.sh Mon May 7 14:07:13 2012 = (r235128) > +++ head/tools/tools/zfsboottest/zfsboottest.sh Mon May 7 15:03:42 2012 = (r235129) > @@ -52,8 +52,7 @@ if [ $? -ne 0 ]; then > fi > bootfs=3D`zpool get bootfs "${pool}" | tail -1 | awk '{print $3}'` > if [ "${bootfs}" =3D "-" ]; then > - echo "The \"bootfs\" property is not configured for pool \"${pool}\"." = >&2 > - exit 1 > + bootfs=3D"${pool}" > fi > # Dataset's mountpoint property should be set to 'legacy'. > if [ "`zfs get -H -o value mountpoint ${bootfs}`" !=3D "legacy" ]; then --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --Y1L3PTX8QE8cb2T+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk+ofm8ACgkQForvXbEpPzQDLACgnjz6GeDb5q0bdTvCp1i0WhvA DwoAni3zFbA+hu8dQcK9DIrnzadImKCe =PPCn -----END PGP SIGNATURE----- --Y1L3PTX8QE8cb2T+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120508020119.GE1395>