From owner-freebsd-fs@FreeBSD.ORG Tue Feb 3 20:00:27 2004 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0276C16A4CE; Tue, 3 Feb 2004 20:00:27 -0800 (PST) Received: from mta7.pltn13.pbi.net (mta7.pltn13.pbi.net [64.164.98.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7836843FEB; Tue, 3 Feb 2004 20:00:17 -0800 (PST) (envelope-from zgh@malfunktion.net) Received: from balrog.thehouse (adsl-68-122-117-229.dsl.pltn13.pacbell.net [68.122.117.229])id i144013P008135; Tue, 3 Feb 2004 20:00:16 -0800 (PST) Received: from [10.0.0.6] (cyclops.thehouse [10.0.0.6]) by balrog.thehouse (Postfix) with ESMTP id 8E5313308; Tue, 3 Feb 2004 19:59:44 -0800 (PST) From: Zack Hobson To: Murata Shuuichirou In-Reply-To: <87ad41z6ru.fsf@fons-adae.s.notwork.org> References: <1074080151.733.51.camel@cyclops.thehouse> <87ad41z6ru.fsf@fons-adae.s.notwork.org> Content-Type: text/plain Message-Id: <1075867224.675.7.camel@cyclops.thehouse> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Tue, 03 Feb 2004 20:00:24 -0800 Content-Transfer-Encoding: 7bit cc: yar@freebsd.org cc: fs@freebsd.org Subject: Re: updating HFS for 5.2R [patch] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2004 04:00:27 -0000 On Mon, 2004-02-02 at 10:16, Murata Shuuichirou wrote: > In message <1074080151.733.51.camel@cyclops.thehouse>, > `zgh@malfunktion.net' wrote: > > With these changes, the code compiles. I can install and load the > > resulting kernel module, and I can sucessfully use newfs_hfs and > > fsck_hfs, but mount_hfs on the same volume always fails with an > > "Input/output error". > > If you have not gotten good results yet, try attached patch. Of > course, your patch is also needed. This is great news, thanks. There is no way I would have figured that out myself. Can you give me any insight into why the changes you made were needed? Anyway, the problems that you're encountering now probably have to do with the fact that I did not properly update some of the locking code in my patch, I simply worked around it to get it to compile. The B_LOCKED (AFAIR) flag disappeared and I worked around the problem by simply defining it in my own code. I think your changes exposed this ugly hack of mine, but this is great news! Now all I need to do (hopefully) is figure out what to use instead of the now-obsolete B_LOCKED flag. Anyone have any ideas? Thanks and regards, -zack