From owner-cvs-src@FreeBSD.ORG  Sun May 30 05:48:43 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2AE8116A4CE; Sun, 30 May 2004 05:48:43 -0700 (PDT)
Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CC68143D49; Sun, 30 May 2004 05:48:42 -0700 (PDT)
	(envelope-from danfe@regency.nsu.ru)
Received: from regency.nsu.ru ([193.124.210.26])
	by mx.nsu.ru with esmtp (Exim 4.30)
	id 1BUPl7-0001z8-NR; Sun, 30 May 2004 19:49:49 +0700
Received: from regency.nsu.ru (localhost [127.0.0.1])
	by regency.nsu.ru (8.12.10/8.12.10) with ESMTP id i4UCpKAT029788;
	Sun, 30 May 2004 19:51:20 +0700 (NOVST)
	(envelope-from danfe@regency.nsu.ru)
Received: (from danfe@localhost)
	by regency.nsu.ru (8.12.10/8.12.10/Submit) id i4UCpK3A029737;
	Sun, 30 May 2004 19:51:20 +0700 (NOVST)
	(envelope-from danfe)
Date: Sun, 30 May 2004 19:51:20 +0700
From: Alexey Dokuchaev <danfe@nsu.ru>
To: Pawel Jakub Dawidek <pjd@freebsd.org>
Message-ID: <20040530125120.GB89299@regency.nsu.ru>
References: <200405290641.i4T6fHhj002797@repoman.freebsd.org>
	<20040530094627.GD12007@darkness.comp.waw.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040530094627.GD12007@darkness.comp.waw.pl>
User-Agent: Mutt/1.4.2.1i
cc: Bill Paul <wpaul@freebsd.org>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/compat/ndis subr_ndis.c src/sys/dev/if_ndis
	if_ndis.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 May 2004 12:48:43 -0000

On Sun, May 30, 2004 at 11:46:27AM +0200, Pawel Jakub Dawidek wrote:
> On Fri, May 28, 2004 at 11:41:17PM -0700, Bill Paul wrote:
> [...]
> +> +static int
> +> +my_strcasecmp(s1, s2, len)
> +> +        const char              *s1;
> +> +        const char              *s2;
> +> +        int                     len;
> +> +{
> +> +        int                     i;
> +> +
> +> +        for (i = 0; i < len; i++) {
> +> +                if (toupper(s1[i]) != toupper(s2[i]))
> +> +                        return(1);
> +> +        }
> +> +
> +> +        return(0);
> +> +}
> +> +
> 
> Could we move it to libkern? I want to use it too.

Couple of questions/comments:

	* is the any difference whether to use toupper() vs. tolower() ?
	* curly braces are probably not needed
	* style(9) fix: space after `return' statement.

./danfe