Date: Wed, 14 Dec 2016 14:03:52 -0800 From: Freddie Cash <fjwcash@gmail.com> To: Akinori MUSHA <knu@idaemons.org> Cc: "Julian H. Stacey" <jhs@berklix.com>, FreeBSD Ports Mailing List <ports@freebsd.org> Subject: Re: No port should need root for make fetch Message-ID: <CAOjFWZ5Bd-JSGniBagyxGLFKhw2PedvZ2Beoai_F7iLPt9=4xg@mail.gmail.com> In-Reply-To: <86y3zinby3.knu@iDaemons.org> References: <201612132032.uBDKWaVK017178@fire.js.berklix.net> <86y3zinby3.knu@iDaemons.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 14, 2016 at 12:37 AM, Akinori MUSHA <knu@idaemons.org> wrote: > Hi, > > Thanks for the info. > > On Wed, 14 Dec 2016 05:32:36 +0900, > Julian H. Stacey wrote: > > Hi ports@ > > IMO No port should need root for > > cd /usr/ports; make -i fetch > > The first one that broke for me was databases/mysql-q4m > > (OK might be others before, but I have DUDS =3D > > arabic biology chinese hebrew hungarian japanese korean > > polish portuguese russian ukrainian vietnamese games demime > > majordomo acroreadwrapper acroread9 chimera dosbox emil > > firefox freerdp gimp-app gv libcue mp3splt-gtk nut opera > > ripit vlc xorg xsane > > ) > > (MAINTAINER CC'd) but there's more ports beyond, usually because > > some ports also go berserk & install, or mabe install dependents. > > Having the dependency as FETCH_DEPENDS [*] was not my idea, but that > was for a reason: you should not fetch a file while building a port. > > * https://svnweb.freebsd.org/ports/head/databases/mysql- > q4m/Makefile#rev297196 =E2=80=8BShouldn't this be split into two, then? =E2=80=8BFETCH_DEPENDS+=3D ${NONEXISTENT}:${PORTSDIR}/databases/mysql${MYSQL_VER}-server:fetch BUILD_DEPENDS+=3D ${NONEXISTENT}:${PORTSDIR}/databases/mysql${MYSQL_VER}-server:build =E2=80=8BThat way, only the fetch target is run on the mysql-server port wh= en running the fetch target on the mysql-q4m port. And the build target is run on the mysql-server port when the build target is run on the mysql-q4m port. Or is there no :fetch support in the _DEPENDS framework?=E2=80=8B --=20 Freddie Cash fjwcash@gmail.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOjFWZ5Bd-JSGniBagyxGLFKhw2PedvZ2Beoai_F7iLPt9=4xg>