From owner-svn-src-head@FreeBSD.ORG Tue Mar 27 01:26:01 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 083A4106566C; Tue, 27 Mar 2012 01:26:01 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id E81B68FC17; Tue, 27 Mar 2012 01:26:00 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q2R1Q0av058527; Tue, 27 Mar 2012 01:26:00 GMT (envelope-from nwhitehorn@svn.freebsd.org) Received: (from nwhitehorn@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q2R1Q0DW058525; Tue, 27 Mar 2012 01:26:00 GMT (envelope-from nwhitehorn@svn.freebsd.org) Message-Id: <201203270126.q2R1Q0DW058525@svn.freebsd.org> From: Nathan Whitehorn Date: Tue, 27 Mar 2012 01:26:00 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r233530 - head/sys/powerpc/aim X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2012 01:26:01 -0000 Author: nwhitehorn Date: Tue Mar 27 01:26:00 2012 New Revision: 233530 URL: http://svn.freebsd.org/changeset/base/233530 Log: Make sure to call vm_page_dirty() before the pmap lock is released to prevent a race where another process could conclude the page was clean. Submitted by: alc Modified: head/sys/powerpc/aim/mmu_oea64.c Modified: head/sys/powerpc/aim/mmu_oea64.c ============================================================================== --- head/sys/powerpc/aim/mmu_oea64.c Tue Mar 27 01:24:18 2012 (r233529) +++ head/sys/powerpc/aim/mmu_oea64.c Tue Mar 27 01:26:00 2012 (r233530) @@ -1582,11 +1582,11 @@ moea64_remove_write(mmu_t mmu, vm_page_t isync(); } } + if ((lo & LPTE_CHG) != 0) + vm_page_dirty(m); PMAP_UNLOCK(pmap); } UNLOCK_TABLE_RD(); - if ((lo & LPTE_CHG) != 0) - vm_page_dirty(m); vm_page_aflag_clear(m, PGA_WRITEABLE); }