From owner-cvs-all@FreeBSD.ORG  Mon Jun 23 09:08:20 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 83971106567E; Mon, 23 Jun 2008 09:08:20 +0000 (UTC)
Date: Mon, 23 Jun 2008 09:08:20 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "QA Tindy (Ion-Mihai Tetcu)" <itetcu@FreeBSD.org>
Message-ID: <20080623090820.GA47866@FreeBSD.org>
References: <200806212017.m5LKHJ0B095308@repoman.freebsd.org>
	<20080621233519.6c15adc6@it.buh.tecnik93.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20080621233519.6c15adc6@it.buh.tecnik93.com>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, Chin-San Huang <chinsan@FreeBSD.org>,
	Mark Linimon <linimon@FreeBSD.org>, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/x11-toolkits Makefile
	ports/x11-toolkits/termit Makefile distinfo pkg-descr
	pkg-plist pkg-plist.DOC
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jun 2008 09:08:20 -0000

On Sat, Jun 21, 2008 at 11:35:19PM +0300, QA Tindy (Ion-Mihai Tetcu) wrote:
> On Sat, 21 Jun 2008 20:17:19 +0000 (UTC)
> Chin-San Huang <chinsan@FreeBSD.org> wrote:
> 
> > chinsan     2008-06-21 20:17:19 UTC
> > 
> >   FreeBSD ports repository
> > 
> >   Modified files:
> >     x11-toolkits         Makefile 
> >   Added files:
> >     x11-toolkits/termit  Makefile distinfo pkg-descr pkg-plist 
> >                          pkg-plist.DOC 
> >   Log:
> >   Small terminal emulator. The only dependencies are Vte and Gtk2 libs.
> >   Termit supports tabs, bookmarks, encoding switching and sessions.

Pardon me, but that is terminal emulator doing in toolkits category?

> >   
> >   WWW: http://code.google.com/p/termit/wiki/TermIt
> >   
> >   Revision  Changes    Path
> >   1.479     +1 -0      ports/x11-toolkits/Makefile
> >   1.1       +54 -0     ports/x11-toolkits/termit/Makefile (new)
> >   1.1       +3 -0      ports/x11-toolkits/termit/distinfo (new)
> >   1.1       +4 -0      ports/x11-toolkits/termit/pkg-descr (new)
> >   1.1       +7 -0      ports/x11-toolkits/termit/pkg-plist (new)
> >   1.1       +4 -0      ports/x11-toolkits/termit/pkg-plist.DOC (new)

It seems that you've been better off with PLIST_FILES/DIRS rather than
messing with dynamic PLIST of 7+4 lines.  As a side note, Makefile logic
is quite hard to follow (why is do-install: needed, it is not clear up
front).  You've also made classic RDEPS=${BDEPS} mistake, the resulting
package, for instance, would have cmake dependency in rdeps per what I
see.

./danfe