From owner-freebsd-stable@FreeBSD.ORG  Fri Oct 24 17:49:55 2003
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8577B16A4B3
	for <freebsd-stable@freebsd.org>;
	Fri, 24 Oct 2003 17:49:55 -0700 (PDT)
Received: from mail.dt.e-technik.uni-dortmund.de
	(krusty.dt.e-technik.Uni-Dortmund.DE [129.217.163.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5C97E43F85
	for <freebsd-stable@freebsd.org>;
	Fri, 24 Oct 2003 17:49:54 -0700 (PDT)
	(envelope-from ma@dt.e-technik.uni-dortmund.de)
Received: from m2a2.dyndns.org (krusty.dt.e-technik.uni-dortmund.de
	[129.217.163.1])5D59A12A3D	for <freebsd-stable@freebsd.org>;
	Sat, 25 Oct 2003 02:49:53 +0200 (CEST)
Received: by merlin.emma.line.org (Postfix, from userid 500)
	id 07BA892E92; Sat, 25 Oct 2003 02:49:51 +0200 (CEST)
To: freebsd-stable@freebsd.org
In-Reply-To: <20031024192152.GD11573@freebsdmall.com> (Murray Stokely's
 message of "Fri, 24 Oct 2003 12:21:52 -0700")
References: <20031024192152.GD11573@freebsdmall.com>
From: Matthias Andree <ma@dt.e-technik.uni-dortmund.de>
Date: Sat, 25 Oct 2003 02:49:51 +0200
Message-ID: <m3he1ynntc.fsf@merlin.emma.line.org>
User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: Final 4.9-RC (i386) available now, please help test.
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Oct 2003 00:49:55 -0000

Murray Stokely <murray@freebsd.org> writes:

> RC4 includes the SATA and DRM fixes, along with a few other
> panic-preventing bugfixes.  If everything goes well we can release 4.9
> on Monday.

May not be release critical, but rather fine tuning:

The install program does strange things, even in -S mode.

A regular -c install operation flow is similar to:

kill destination file
open destination file with mode 0600
copy content
close
fchmod
fchflags

Problem: there is a short period where the program, when overwritten, is
not executable ("permission denied").

One could think install -S (S for safe) would fix that, but it doesn't,
strace:

rename("/tmp/INS@02eI", "/tmp/x2")      = 0
  <- here the /tmp/x2 file is not accessible
close(4)                                = 0
open("/tmp/x2", O_RDONLY)               = 4
fstat(4, {st_mode=S_IFREG|0600, st_size=0, ...}) = 0
fchmod(4, 0755)                         = 0
fchflags(4, 0)                          = 0

I'd suggest the order be

fchmod
close
rename
open
fchflags
...

That way, the program installed will always be executable if the user
tells FreeBSD to "install -S".

-- 
Matthias Andree

Encrypt your mail: my GnuPG key ID is 0x052E7D95