From owner-freebsd-gecko@freebsd.org Sun Mar 17 20:01:25 2019 Return-Path: Delivered-To: freebsd-gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B6B31548D34 for ; Sun, 17 Mar 2019 20:01:25 +0000 (UTC) (envelope-from ml+freebsd@vishwin.info) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6AEF08EBD7 for ; Sun, 17 Mar 2019 20:01:24 +0000 (UTC) (envelope-from ml+freebsd@vishwin.info) Received: by mailman.ysv.freebsd.org (Postfix) id 2B2E21548D29; Sun, 17 Mar 2019 20:01:24 +0000 (UTC) Delivered-To: gecko@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 073611548D1B for ; Sun, 17 Mar 2019 20:01:24 +0000 (UTC) (envelope-from ml+freebsd@vishwin.info) Received: from varun.vishwin.info (varun.vishwin.info [46.101.93.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "varun.vishwin.info", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 610CF8EBD2; Sun, 17 Mar 2019 20:01:23 +0000 (UTC) (envelope-from ml+freebsd@vishwin.info) Received: from varun.vishwin.info (fd35:9eae:7575::2 [IPv6:fd35:9eae:7575::2]) by varun.vishwin.info (OpenSMTPD) with ESMTP id 6c225346; Sun, 17 Mar 2019 15:54:38 -0400 (EDT) Received: from [IPv6:2001:470:8:6ca:cad7:19ff:fec0:a06d] (2001:470:8:6ca:cad7:19ff:fec0:a06d [IPv6:2001:470:8:6ca:cad7:19ff:fec0:a06d]) by varun.vishwin.info (OpenSMTPD) with ESMTPSA id 204727c8 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Sun, 17 Mar 2019 15:54:38 -0400 (EDT) Subject: Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro To: Jan Beich , Graham Perrin Cc: gecko@freebsd.org References: <496db844-cb0b-1b53-b498-beec9324b9c0@gmail.com> From: Charlie Li Openpgp: preference=signencrypt Autocrypt: addr=ml+freebsd@vishwin.info; keydata= mQINBFt7iHUBEADCorTixbMGuHd9WYSKCELlv/TFcRtvpHUw/n9LtXzKixUUwl7iuMFMYTz3 QXePX0Twq4jCQYySfcxWbPkLsSYlPOkaGQ+XytfmIHoqG5ba4i1fp+F41is0oCtLt1+oL84j NKUd13em/JWd+PJeQbSTVnHbT2yaAi7vqWw5WKVaMExjfPGU5TArV46wSRU6Zuy1ZX66q0q5 dPzeBdeKYWJE8aGtyi3pYUpKUOX4gxiNetf6leDFZ4OsexWaRdU0n8fId5d1qwjAE3lOwV5z 0Ilt8t4iXtX3JL3DAQyLZIeXHIg9O3rrpPMXQWSp2/5g39PohNk7farbhcpIKxuDN+L5N6U9 OxNHBSCv9FGDO4R/mw3YwJCovDzsF7RSyXQDIY36yjdh2uTLZ0uD5Ci/DPmJUySFLRvpqWnQ M7V5cYhdqDfcElGpRbi8JZQVYRJjvI5Jj0byG98KeaD0YFxKqmmm+Oh+xWXE7xt/DsBoZeZJ BFP84LvFbwQqprvI+sg+1z2+JIgNbYwl8VaYzfyGnqTEXTOsQYEKTdKA9MODSAsN31MlQICe CIHZV+OwOqH1KQ/mZp59AnpXAmj4T94bnahE9yJtVW/qglX/nTeFNUdu5MyEgkeB0x7mx+t0 3hE20yp/NbyvG1T/o53NHwHiURC/8Fxd1NWPZ6n4X8npQn6iyQARAQABtC5DaGFybGllIExp IChGcmVlQlNEKSA8bWwrZnJlZWJzZEB2aXNod2luLmluZm8+iQJOBBMBCAA4FiEE/3/Cqr5a +41PbEb+jnB43vIDq2wFAlt7iwoCGyMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQjnB4 3vIDq2zlBQ/7Boe3K9i4pxvIlBWlFDmDuclLiju/LTsc81mO607TIwUMx5p3BfnhqTwqpcuT Gilj2JKSlIw0NioJ3HnPiPyIpMmOmdeLBwvBn8iBmjs14DdDMgKusE8gKc0KRFbTM397rB7K oXj2/R8VF3Uuo8i3vlWyah6p+Osz1dAad/7COqPeM9OBMKaYAOrdKvxMC96l5k+Wc1JKOLeA BP7BtgmQB7HydHUm+dzqUB1rgMP2djIXd5Ngc749kzNQIFvC9ZXbaABw5M4JqKRbVFm08Wgw IUyhkNEtMpkBxMPwqXsk3t1KVptYQSAfW/+8mWDP2sgUOyz9O2IBfb1acCPk04/jf8SsXRaT HzJr64NseWlZUHAMYl9EC09gdE6UDCIHR68+IzutMtgT17Djuu1HRYly+RWAGkyTOeR7Sv/V 2B89Nsq5OfHYs3F2vD57/aRj5TmZJDQWxH/rDYbj8Pk6UjXcaY6QWUtNFidvCMFlBpXuncXU ZWgTsJEyZLHP5SJ7S9sRSHU5+CVUkjsbEFNuHkkGHAkSnpP+HosnH8/q9Rykn9FTamLbiQRQ UxJ6+IlqvOUtRRrMGMBF7ZIFGHcl8tcKynsPTeaHjpqPhCrZx8PmCKKoJHwW4Ua7+cdZkBJq R20qvXuLIrInjkIpA1CbacMckS5a7el6pi/nU0NG1S1K4Zu5Ag0EW3uIdQEQANdl7YHG8JOy HbEYv+7ExSrO96qBRavg1FsDG0riDmlsOSfZ2fqL6/YJF5WsfsX99+YSdIiLQfC4QOw/cA+M I65pgY4cCu42L7YIW/AR+jB1hFg+Q/cbeOwjuKPFYtZvxeDpSsaA6iIR+p+t4DXkjWl86g6W aFLC+til/rCilFHY/1/6M918F1gm/6xCIADDFu0BXLkASc5B4LuvaFEiJIuI9ZoQDIgWxnsX 0tXXE36SwK/XrowzRzsOa+2iOHAPKu7rPGHwy28vO4T5Uq7UynMZG2sK3RTbOijaxL4IJF4W MRqpuGdBSJ4sWmr5aIpgX9au5L1TNAAILJpHXnkv+k825+9VgbhFtFYBHEkgUtXb+w34JnkH okpr9A78dpWb+T+jOEP6ZUgM+4VVy+hCCpbcCVI2PEXu8w2z3+4yZWxIFmy8UYZRoeTMKzV2 zLeisoA0XA8jj548YNPiAl20Mjyoqu42WNv0P8fD9PMTcfLFCj2PlxOhuUFaIUH3ty0/bNeS jPtVK+L9x4W37R7U1tYk+tB5MlPakQiSQtdToB+8K34rnBt/3kCoAYL7Hygw9+qyZrEKZDtP 5JKekfgsy28t1z66xWCUwq9PHuUFiij3cjbwIbskI9uy2+xITcXt4ZqVfpZcdGmjfbdTPkGf PH2pjDoCJaezYdbha/3OVhmVABEBAAGJAjYEGAEIACAWIQT/f8Kqvlr7jU9sRv6OcHje8gOr bAUCW3uIdQIbDAAKCRCOcHje8gOrbExnD/9qwSL4HiorJmUEJ+5CTh8IJql4PzeQK8Dx93gi Zs5jWVlCJTmcpQNirWIZM2eRt67C/wTJjLmEVGzySVLpGiUqhXqdROgFmDwvEnmpIbtWWyvG sgSOCmZj/tz0GEtLSsjJcV/kLffkv7XEKkt9ZjIJnFYVYSovDK1o2PoO6Rfi5AWHHB7jYhjS HJvJjDx0yClO9gEYhtw7R60YOLH+cKoDou9tu+4wR3QwRsNGO6wrzLGhptxuBrDMI+HuOx+j wBTliuzuvZrry6OdKDDdq5D4vvQCj4vFnK4p7LZXhBshCMoLkWoA0I2T+YF/V5Ob5EuvsTIC re/pO/g941ipVkehvVNAsiplSaHjasB1HS6BQ95csI8E/b6PnKm+IECp2bANbLP1jrxKeBGj UkeyRxTmOV/ADUIIj8S4a2yOxTxlysN2O5wqXCJcxaYelC/Y4TUcL6ENxn2dLBdCYKQEna0u DdxZp7fS+pXN6qyK8Qz6Q42MHAxFAZdLKf6a44d4HQt6rPcWdETVlnVKnJr0b9kg5K1Q8N4k PVoTGVrkGAZhmjFYsqWulq445VU46mX7WcqsrZx8LqNTwP6i3Bf71FJ9EBxTyA8fP8k0qosP 8U8D7jhcc5x4yVW8RBBtB+a5q3odWdFnjMLEm4wtxBH/mSN/UKRcFSBvKQ8FxTgpX4Yxcw== Organization: FreeBSD Message-ID: <1a8a2cd4-fce2-5dca-ec4a-a417d783f56a@vishwin.info> Date: Sun, 17 Mar 2019 15:54:29 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tHcPwBBQgb86OCd4LcWvnxGyaNYNo3Ec2" X-Rspamd-Queue-Id: 610CF8EBD2 X-Spamd-Bar: ------ X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[freebsd]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Mar 2019 20:01:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tHcPwBBQgb86OCd4LcWvnxGyaNYNo3Ec2 Content-Type: multipart/mixed; boundary="aWC9jlW58SNAe5AQdVO8Qf7OEXLXPFvbn"; protected-headers="v1" From: Charlie Li To: Jan Beich , Graham Perrin Cc: gecko@freebsd.org Message-ID: <1a8a2cd4-fce2-5dca-ec4a-a417d783f56a@vishwin.info> Subject: Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro References: <496db844-cb0b-1b53-b498-beec9324b9c0@gmail.com> In-Reply-To: --aWC9jlW58SNAe5AQdVO8Qf7OEXLXPFvbn Content-Type: text/plain; charset=utf-8 Content-Language: en-GB-large Content-Transfer-Encoding: quoted-printable On 17/03/2019 12:25, Jan Beich wrote: > Graham Perrin writes: >=20 >> error: missing documentation for macro >> -->=20 >> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/= style_traits/values.rs:341:1 >> | >> 341 | macro_rules! define_css_keyword_enum { >> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> | >> note: lint level defined here >> -->=20 >> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/= style_traits/lib.rs:12:22 >> | >> 12 | #![deny(unsafe_code, missing_docs)] >> | ^^^^^^^^^^^^ >=20 > Looks like a regression from Rust 1.33 update. >=20 > Either remove missing_docs from #![deny(...)] lines (or lines themselve= s) > for each one that triggers error (no need to bother with unused ones) o= r > add MOZ_OPTIONS+=3D--disable-stylo to Makefile.local. >=20 > www/firefox-esr et al. simply backported upstream fixes for warnings to= > avoid having to maintain workarounds forever. Rebasing those against > very old Stylo code isn't worth the effort. >=20 I simply followed the tip given in Mozilla bug 1521249 (remove `#![deny(missing_docs)]`), and have been running with it since we updated our lang/rust to 1.33: https://bugzilla.mozilla.org/show_bug.cgi?id=3D1521249#c36 Mozilla upstream are concerned about keeping compatibility with older rust, especially for their ESR. Since we only ship the latest version of rust at a time, we don't have to worry about that sort of compatibility, so backport away. --=20 Charlie Li =E2=80=A6nope, still don't have an exit line. (This email address is for mailing list use; replace local-part with vishwin for off-list communication if possible) --aWC9jlW58SNAe5AQdVO8Qf7OEXLXPFvbn-- --tHcPwBBQgb86OCd4LcWvnxGyaNYNo3Ec2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE/3/Cqr5a+41PbEb+jnB43vIDq2wFAlyOpf0ACgkQjnB43vID q2yRFQ/+LBE7kspQnwk9LLK9iafDLtRmpKP6BVkf2kLq4yE+DxwhMFuZNdJ61/X9 vIr7CBjVstDqXTYgk50L4lh6tdVJYoID2xUN8bxY2qGVn7KjSSW9Gx+kB+FvJlEm xLrl7rEqWpj7bB9BY76Y1ipBqKApCFy8e3a/lxPO7ZCrwoo2wPjc2zMWnu/P64jb 3/VKdDAXClDCvYSZmE0ej8yOr1entLwEgPPbxKw9e6SWh+q9L2H3+Qe5tc+lkeQY 8Jh19Rt40nsrLgKxQxcSTf9yA4yiMgnaoWRbXV1n/ewSlqF/uRDfKTWz7+KZhKth e09eZzhXd3ShViAM31aHTelPVkfZ4C3RsbTxbYHUWd67RxtgT9j61S7I33Qe6edk rUcFyL0c469HmWVuu3ozd2OP6VvL0P3Tr9ipWFoDskb8F3K56HdMS9iG1HCc0hJW gy7pWiCNy+nYhCius+Ridu1ZNHi8BlLhayrwF4fzNNw7SCRx3CActtWXDjQm3QJ6 rgVni9WIqBS8mql0s8o1ogdvQfgXF+bxGA3LrnmhIV3bxGrXBbjdINi7U8Z50Z3L FgDgV3HLsIIxJNVmrZ7GQsJV7UknLzT7etEg1y5Zou83iy2G6ry8nC4ZfW4D0deT l0gBg5kL+nHieFZdCo+jKLxYabzxi7BhJsD3EVs6btmXjy7xyrE= =KHb1 -----END PGP SIGNATURE----- --tHcPwBBQgb86OCd4LcWvnxGyaNYNo3Ec2--