From owner-freebsd-current  Wed Sep 12 10: 2:58 2001
Delivered-To: freebsd-current@freebsd.org
Received: from mail.wrs.com (unknown-1-11.windriver.com [147.11.1.11])
	by hub.freebsd.org (Postfix) with ESMTP
	id 47B1837B408; Wed, 12 Sep 2001 10:02:55 -0700 (PDT)
Received: from laptop.baldwin.cx (john@[147.11.46.201])
	by mail.wrs.com (8.9.3/8.9.1) with ESMTP id KAA28815;
	Wed, 12 Sep 2001 10:02:53 -0700 (PDT)
Message-ID: <XFMail.010912100247.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20010912124407.E73589@sunbay.com>
Date: Wed, 12 Sep 2001 10:02:47 -0700 (PDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Subject: Re: HEADSUP!!!! KSE Milestone-2 COMMITTED
Cc: current@FreeBSD.org, Julian Elischer <julian@elischer.org>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


On 12-Sep-01 Ruslan Ermilov wrote:
> Hello Julian!
> 
> Could you please post the list of all changed and new kernel
> API functions so that -doc guys can keep up with this?
> 
> Like suser_td(9), etc.

suser_td() is going away.  p_ucred in the KSE kernel is still per-process, and
we need to hold the proc lock while we call suser() as a result (and we have to
hold it for the result of the test, so pushing the lock down into suser_td() is
not feasible).  Thus, code that does this:

        error = suser_td(td);
        if (error)
                return (error);

is going to become this:

        struct proc *p = td->td_proc;

        PROC_LOCK(p);
        error = suser(p);
        if (error) {
                PROC_UNLOCK(p);
                return;
        }
        .... /* do stuff */
        PROC_UNLOCK(p);

I originally asked that the suser_td() changes not be made so that the locking
code doesn't have to go back all of them out again thus increasing the overall
diff size.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message