From owner-freebsd-ports@FreeBSD.ORG  Wed Apr 16 13:55:41 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9C82C106564A;
	Wed, 16 Apr 2008 13:55:41 +0000 (UTC)
	(envelope-from ganael.laplanche@martymac.com)
Received: from data.galacsys.net (data.galacsys.net [217.24.81.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 591318FC1C;
	Wed, 16 Apr 2008 13:55:41 +0000 (UTC)
	(envelope-from ganael.laplanche@martymac.com)
Received: from martymac.com (webmail.galacsys.net [217.24.81.215])
	by data.galacsys.net (Postfix) with ESMTP id A361F16BAC4;
	Wed, 16 Apr 2008 15:55:39 +0200 (CEST)
From: "Ganael LAPLANCHE" <ganael.laplanche@martymac.com>
To: "Anatoly Borodin" <anatoly.borodin@gmail.com>,
	"Ganael LAPLANCHE" <ganael.laplanche@martymac.com>
X-Openwebmail-Date: Wed, 16 Apr 2008 15:55:39 +0100
Message-Id: <20080416134523.M15457@martymac.com>
In-Reply-To: <e1e1b0290804160601w5dce2c38xfec27bffa15271ae@mail.gmail.com>
References: <48053F56.4090404@FreeBSD.org> <20080416064154.M28876@martymac.com>
	<4805BB13.1050007@FreeBSD.org> <20080416094711.M99470@martymac.com>
	<e1e1b0290804160601w5dce2c38xfec27bffa15271ae@mail.gmail.com>
X-Mailer: Open WebMail 2.01 20030425
X-OriginatingIP: 157.99.64.43 (ganael.laplanche@martymac.com)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Date: Wed, 16 Apr 2008 15:55:39 +0200 (CEST)
Cc: ports@freebsd.org, Pietro Cerutti <gahr@freebsd.org>
Subject: Re: CFT: devel/directfb update to 1.1.1
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Apr 2008 13:55:41 -0000

On Wed, 16 Apr 2008 16:01:43 +0300, Anatoly Borodin wrote
> Hi!

Hi :)

> 1) Did your mplayer work with the previous version of directfb?

No, since the previous version of directfb didn't install neither sdl nor x11
drivers.

> 2) Have you rebuilt mplayer?

Yes, using --enable-directfb. The lib is detected, everything is built
(hopefully) correctly.

> links doesn't work with directfb on my machine, so I'll investigate
> the reason pretty soon. And I think it will good to fix mplayer and
> add directfb flags to the ports.
> 
> >  % env DFBARGS=system=sdl ./mplayer -vo directfb test.avi
> 
> Try to run it with system=x11 please and tell what happens.

It produces the same error as previously reported : "No system found!". Very
strange, but applying those two patches allows the libs to be found and mplayer
to (nearly) start :

--- lib/direct/interface.c.orig 2008-04-12 13:25:57.542006795 +0200
+++ lib/direct/interface.c      2008-04-12 13:26:27.732927708 +0200
@@ -164,7 +164,7 @@
      /*
       * Iterate directory.
       */
-     while (readdir_r( dir, &tmp, &entry ) == 0 && entry) {
+     while (entry = readdir( dir )) {
           void *handle = NULL;
           char  buf[4096];

--- lib/direct/modules.c.orig   2008-04-12 13:25:45.166038341 +0200
+++ lib/direct/modules.c        2008-04-12 13:27:56.054698492 +0200
@@ -158,7 +158,7 @@
           return 0;
      }

-     while (readdir_r( dir, &tmp, &entry ) == 0 && entry) {
+     while (entry = readdir( dir )) {
           void              *handle;
           DirectModuleEntry *module;
           int                entry_len = strlen(entry->d_name);

Best regards,

Ganaël LAPLANCHE
ganael.laplanche@martymac.com
http://www.martymac.com