From owner-freebsd-current Wed Nov 27 15:05:05 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA20305 for current-outgoing; Wed, 27 Nov 1996 15:05:05 -0800 (PST) Received: from critter.tfs.com ([140.145.230.177]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id PAA20295; Wed, 27 Nov 1996 15:05:00 -0800 (PST) Received: from critter.tfs.com (localhost.dk.tfs.com [127.0.0.1]) by critter.tfs.com (8.8.2/8.8.2) with ESMTP id AAA03254; Thu, 28 Nov 1996 00:05:39 +0100 (MET) To: Bruce Evans cc: current@FreeBSD.org Subject: Re: users of "ft" tapes, please test! In-reply-to: Your message of "Thu, 28 Nov 1996 09:49:44 +1100." <199611272249.JAA32491@godzilla.zeta.org.au> Date: Thu, 28 Nov 1996 00:05:24 +0100 Message-ID: <3252.849135924@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In message <199611272249.JAA32491@godzilla.zeta.org.au>, Bruce Evans writes: >>Unless somebody convinces me that this patch doesn't work, It will >>be committed. It shaves about 5K of the size of the ft.o object >>file. > >There are several other places with big static buffers, but I thought >that the savings for making them dynamic would be negative for kzipped >kernels. How much is saved by this change? 4k in VM-space available for user-land. A seriously strained resource if 4MB installs are to be possible. >Why don't people check the the value returned by malloc()? malloc() >is unlikely to fail at probe time (except on 4MB machines :-), and >the null pointer panic isn't much different from panic("malloc failed") >but it is harder to debug. How about a new flag M_NOFAIL which causes >a panic if malloc() would fail. M_WAITOK is rarely correct in probes >(hanging is worse than panicing) and M_NOWAIT is inconvenient if you >actually check for errors. Good idea. Maybe, M_PANICFAIL is more obvious. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so.