From owner-svn-src-head@FreeBSD.ORG Mon Dec 30 01:41:33 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0B42F894 for ; Mon, 30 Dec 2013 01:41:33 +0000 (UTC) Received: from nm15-vm6.bullet.mail.ne1.yahoo.com (nm15-vm6.bullet.mail.ne1.yahoo.com [98.138.91.108]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BEBA618F0 for ; Mon, 30 Dec 2013 01:41:32 +0000 (UTC) Received: from [98.138.101.129] by nm15.bullet.mail.ne1.yahoo.com with NNFMP; 30 Dec 2013 01:36:04 -0000 Received: from [98.138.84.41] by tm17.bullet.mail.ne1.yahoo.com with NNFMP; 30 Dec 2013 01:36:04 -0000 Received: from [127.0.0.1] by smtp109.mail.ne1.yahoo.com with NNFMP; 30 Dec 2013 01:36:04 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1388367364; bh=chi1UUPnrgDPi7VEOCjCbGGLN6TSyPiG/t+DbMjylnE=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; b=EYw2Xx2VRI6pSNHEy2xSKMTNEUhH1FbA6Z7g9P+pT3BkG9d4DVoNpqsU3jLL9ZWNQgosuoW5USO4Rg/WC0s/8gxJn6kgnBfIUpwfGH2+y5u72dUugG+K76azqdEcGqhXmLSksRIHiyWK+qDpYZzM6m7Kmibw3zE7FidYb8jvWB0= X-Yahoo-Newman-Id: 156983.82151.bm@smtp109.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: eCLRElsVM1kVXLDu3WZeqtkazabaETkY2_YAwhGNDFl0uP1 fzhn5VhXc__jVJGV8w400S3BU1hqqxpD0KjoCLGcLmSNkXWmvbos2jJzQ4KM E9v6.XqQhkfze6Hd0kNnlL2FRVDboHROpNxFdZY7JW0yrjr0deUjyrhiuJHT dp70N8PUr7Gd9KEITijw7seAMN0Ght1v.jxYUKPx_PUs0pSyepLz0YEVAT4w tZbeUXVykzyErASMc4oAj8JoAjf.YIWnMzOIwP1LaLnViJHXPY4o.9p6hiGt MG8kdSp2E8pZBFyX6r9LCx.Kcoy0OgWJVcrD6bZvE6SoyKRvfDpm_5OiWAvt .MpkmB9HvuiDGN7pXwsdACfTrO9eOUeCn6uu92RtIakXv8Q_m_ocr2KKX.hu ea1nroO_3MfvC_rp7aEiWVHOaaQ_GxmPcX0ih2vt6qzjEen1m5Hal2yeBLz7 JwWGreN97KmXeDZKunisNYLno4y5Qr32yexf5zofBkw0WGVOR3RmiX1beYjS wv4Qyw4vrDty0fS8en_kRzDFoDmufUs5oClFhgKprd0fPt_4Z9BWvVz6CAwM h1amq8uMF0Ta2gQ-- X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- X-Rocket-Received: from lglt-nvaradarajan.corp.netflix.com (scott4long@69.53.236.251 with plain [98.139.211.125]) by smtp109.mail.ne1.yahoo.com with SMTP; 29 Dec 2013 17:36:04 -0800 PST Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: svn commit: r259896 - head/sys/dev/cxgb/common From: Scott Long In-Reply-To: <20131229212825.GE99167@funkthat.com> Date: Sun, 29 Dec 2013 18:35:59 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <7E3BD20D-C9EB-46B4-8744-D7F99100E408@yahoo.com> References: <201312252245.rBPMjX5J046556@svn.freebsd.org> <76C5CECF-1A27-4245-B5D1-335C46B253E7@FreeBSD.org> <52C08B47.70106@FreeBSD.org> <20131229212825.GE99167@funkthat.com> To: John-Mark Gurney , Pedro Giffuni , Adrian Chadd , Dimitry Andric X-Mailer: Apple Mail (2.1827) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Dec 2013 01:41:33 -0000 On Dec 29, 2013, at 2:28 PM, John-Mark Gurney wrote: > Pedro Giffuni wrote this message on Sun, Dec 29, 2013 at 15:51 -0500: >> On 26.12.2013 06:13, Dimitry Andric wrote: >>> On 26 Dec 2013, at 02:51, Adrian Chadd wrote: >>>> I'd prefer you didn't remove unused code in drivers like this. If = you >>>> must, #if 0 them out. >>> I don't mind either way, but some other people are very much opposed = to >>> littering code with #if 0'd sections. So, how do to determine what = is >>> right in each situation? :-) >>>=20 >>=20 >> FWIW, I am also in favor of removing instead of #if 0. >> If we really need the code back, we have subversion for that. >>=20 >> I guess an exception would be on contributed code, where one >> still wants to keep things similar. >>=20 >> Just my 0.02$, no strong feelings about either way. >=20 > My vote for code like this to #if 0 it out.. The reason being is > that this is generic hardware register access, and it's likely that > if it is removed and someone needs it, they'll write their own > instead of dig it out of history, since they might not even realize > that it even existed... >=20 > Though can't we annotate it as unused? Since it is static inline, the > compiler should end up not including it in the object. >=20 Since it=92s code that has an active maintainer, why not ask him instead of pretending that all of our opinions are more important? Scott