From owner-freebsd-ports@FreeBSD.ORG Thu Jun 25 12:27:41 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C49181065672 for ; Thu, 25 Jun 2009 12:27:41 +0000 (UTC) (envelope-from laszlof@freebsd.org) Received: from wookie.tvog.net (wookie.tvog.net [66.232.114.123]) by mx1.freebsd.org (Postfix) with ESMTP id 81C8A8FC12 for ; Thu, 25 Jun 2009 12:27:41 +0000 (UTC) (envelope-from laszlof@freebsd.org) Received: from c-24-98-139-235.hsd1.ga.comcast.net ([24.98.139.235] helo=[192.168.0.2]) by wookie.tvog.net with esmtpa (Exim 4.69) (envelope-from ) id 1MJo3D-0006SO-Uh; Thu, 25 Jun 2009 08:27:36 -0400 Message-ID: <4A436D2F.3070705@freebsd.org> Date: Thu, 25 Jun 2009 08:27:27 -0400 From: "Frank J. Laszlo" User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: Johan van Selst References: <20090619093724.GH3582@obspm.fr> <28283d910906191559j95c1a32t2a76f5bd766594ad@mail.gmail.com> <4A3FE24B.5080208@p6m7g8.com> <4A42256C.3030706@freebsd.org> <20090625083512.GA2713@mud.stack.nl> In-Reply-To: <20090625083512.GA2713@mud.stack.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - wookie.tvog.net X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - freebsd.org Cc: "Carlos A. M. dos Santos" , "Philip M. Gollucci" , Helmut Schneider , freebsd-ports@freebsd.org Subject: Re: vim ports broken. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2009 12:27:42 -0000 Johan van Selst wrote: > Carlos A. M. dos Santos wrote: > >>>> Choosing "%" to differentiate it, however, was a bad idea. It would >>>> be better to use a simple underscore. >>>> >>> Why is % any worse than an underscore? As I explained earlier, fetch has no >>> problem dealing with it. The errors people were posting are server-side, >>> ftp.freebsd.org has no problems handling it. >>> >> POLA: users get surprised by the "Bad Request" answer and think that >> the package is broken. So they complain at -ports, generating lengthy >> email threads. >> > > I have another suggestion: why not tell it that this specific patch file > should be fetched from the FreeBSD server and not try all the other vim > mirror sites. We have a mechanism to do so, which seems appropriate here. > > > Johan > > --- Makefile.orig 2009-06-25 10:24:08.000000000 +0200 > +++ Makefile 2009-06-25 10:21:52.000000000 +0200 > @@ -16,7 +16,7 @@ > DISTFILES= ${RELEASE}${EXTRACT_SUFX} > > PATCH_SITES= ${MASTER_SITES:S|unix|patches/${PORTVERSION:C/\.[0-9a-z]*$//}|}\ > - ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/local-distfiles/obrien/ > + ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/local-distfiles/obrien/:local > PATCHFILES!= /usr/bin/jot -s " " -w ${PORTVERSION:C/\.[0-9]*$//}.%03d \ > ${PATCHLEVEL} 1 ${PATCHLEVEL} > # bits to remove > @@ -27,7 +27,7 @@ > .for p in ${BADPATCHES} > PATCHFILES:= ${PATCHFILES:N7.2.${p}} > .endfor > -PATCHFILES:= ${PATCHFILES:S/041/041%/} > +PATCHFILES:= ${PATCHFILES:S/041/041%:local/} > > MAINTAINER?= obrien@FreeBSD.org > COMMENT?= Vi "workalike", with many additional features > > I figured there was a mechanism for this, but I honestly did not look into it. I would suggest submitting this as a PR so the maintainer see's it, as he has yet to comment on this thread. -- Frank Laszlo laszlof@FreeBSD.org FreeBSD Ports Committer