From owner-freebsd-arch@FreeBSD.ORG Sun Oct 3 22:43:42 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5880516A4CE for ; Sun, 3 Oct 2004 22:43:42 +0000 (GMT) Received: from duchess.speedfactory.net (duchess.speedfactory.net [66.23.201.84]) by mx1.FreeBSD.org (Postfix) with SMTP id BD44243D55 for ; Sun, 3 Oct 2004 22:43:41 +0000 (GMT) (envelope-from ups@tree.com) Received: (qmail 31878 invoked by uid 89); 3 Oct 2004 22:43:40 -0000 Received: from duchess.speedfactory.net (66.23.201.84) by duchess.speedfactory.net with SMTP; 3 Oct 2004 22:43:40 -0000 Received: (qmail 31871 invoked by uid 89); 3 Oct 2004 22:43:40 -0000 Received: from unknown (HELO palm.tree.com) (66.23.216.49) by duchess.speedfactory.net with SMTP; 3 Oct 2004 22:43:40 -0000 Received: from [127.0.0.1] (localhost.tree.com [127.0.0.1]) by palm.tree.com (8.12.10/8.12.10) with ESMTP id i93Mhdmt039850; Sun, 3 Oct 2004 18:43:40 -0400 (EDT) (envelope-from ups@tree.com) From: Stephan Uphoff To: Julian Elischer In-Reply-To: <41607192.8020809@elischer.org> References: <1096489576.3733.1868.camel@palm.tree.com> <200409291652.29990.jhb@FreeBSD.org> <1096496057.3733.2163.camel@palm.tree.com> <1096603981.21577.195.camel@palm.tree.com> <1096608201.21577.203.camel@palm.tree.com> <20041001141040.GA1556@peter.osted.lan> <1096647194.27811.12.camel@palm.tree.com> <20041001192551.GA3381@peter.osted.lan> <415EEFFE.5080309@elischer.org> <20041002183120.GA1202@peter.osted.lan> <415FA496.6000902@elischer.org><41607192.8020809@elischer.org> Content-Type: text/plain Message-Id: <1096843419.38592.76.camel@palm.tree.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Sun, 03 Oct 2004 18:43:39 -0400 Content-Transfer-Encoding: 7bit cc: Peter Holm cc: "freebsd-arch@freebsd.org" Subject: Re: scheduler (sched_4bsd) questions X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Oct 2004 22:43:42 -0000 On Sun, 2004-10-03 at 17:39, Julian Elischer wrote: > Stephan Uphoff wrote: > you didn't answer this question.. > > > > > > >>Where is the critical_enter that matches the extra critical_exit() > >>you put in sched_switch()? I haven' been able to yet figure out how > >>you don't get a double exit. but I've only looked for a few minutes. > > > > ==== //depot/projects/nsched/sys/kern/sched_4bsd.c#58 - > /home/julian/p4/nsched/sys/kern/sched_4bsd.c ==== > @@ -844,6 +844,8 @@ > if (newtd == NULL || newtd->td_ksegrp != td->td_ksegrp) > slot_fill(td->td_ksegrp); > } > + critical_exit(); > + td->td_pflags &= ~TDP_OWEPREEMPT; > } > if (newtd) { > /* > > > where is the matching critical_enter()? > >From Peter's unified diff: RCS file: /home/ncvs/src/sys/kern/sched_4bsd.c,v retrieving revision 1.65 diff -u -r1.65 sched_4bsd.c --- sys/kern/sched_4bsd.c 16 Sep 2004 07:12:59 -0000 1.65 +++ sys/kern/sched_4bsd.c 2 Oct 2004 14:46:29 -0000 @@ -823,6 +823,7 @@ TD_SET_CAN_RUN(td); else { td->td_ksegrp->kg_avail_opennings++; + critical_enter(); if (TD_IS_RUNNING(td)) { /* Put us back on the run queue (kse and all). */ setrunqueue(td, SRQ_OURSELF|SRQ_YIELDING); @@ -834,6 +835,8 @@ */ slot_fill(td->td_ksegrp); } + critical_exit(); + td->td_pflags &= ~TDP_OWEPREEMPT; } if (newtd == NULL) newtd = choosethread();