From owner-freebsd-current@FreeBSD.ORG  Wed Oct 22 11:00:26 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 24B3E106569D;
	Wed, 22 Oct 2008 11:00:26 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:3fb::211])
	by mx1.freebsd.org (Postfix) with ESMTP id DDB0C8FC14;
	Wed, 22 Oct 2008 11:00:25 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id D0A9C1CD19; Wed, 22 Oct 2008 13:00:24 +0200 (CEST)
Date: Wed, 22 Oct 2008 13:00:24 +0200
From: Ed Schouten <ed@80386.nl>
To: d@delphij.net
Message-ID: <20081022110024.GI16837@hoeg.nl>
References: <48FEE8B0.7090906@delphij.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="2KNN3gYh9MUZz6n4"
Content-Disposition: inline
In-Reply-To: <48FEE8B0.7090906@delphij.net>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: [patch] fix build wrt ppbus
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Oct 2008 11:00:26 -0000


--2KNN3gYh9MUZz6n4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Xin LI <delphij@delphij.net> wrote:
> Here is a patch which can (presumbly) fix ppbus build issue...  I don't
> think I'm familiar with the code enough so I'd like to seek review from
> someone else.

I think it's better to abuse si_drv0 to store this data, which is why I
used dev2unit(). In the very far future we could decide to get rid of
make_dev()'s unit number and expose si_drv0 directly to the driver,
which is why I think that approach would be best for now.

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--2KNN3gYh9MUZz6n4
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkj/B8gACgkQ52SDGA2eCwXrSgCeMf2Z5jUawMZh6+55BC2Etel7
ne4AnjhQzW9yN4Llci7EVVbLohW1aH3y
=3p/7
-----END PGP SIGNATURE-----

--2KNN3gYh9MUZz6n4--