Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Dec 2015 10:03:58 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        scsi@freebsd.org
Subject:   Minor improvement in debugging
Message-ID:  <DA1D0AF2-C967-47F7-8110-FA91B1E6281B@bsdimp.com>

next in thread | raw e-mail | index | archive | help

--Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

While writing the NVMe CAM attachment, I noticed that the xpt_action()
routine=E2=80=99s logging would be a lot more useful if we logged the =
function
code. In addition, it is useful to log calls to the SIM inside of
xpt_action_default(). Some sims have debugs, others don=E2=80=99t.

This review fixes that. https://reviews.freebsd.org/D4382

Warner

P.S. I=E2=80=99ll be sending out a bunch of review pointers to this =
list.
If there=E2=80=99s a more-preferred way to do this, please let me know.


--Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJWYcd/AAoJEGwc0Sh9sBEAwjQP/iITi2x1+0kqtMQ1s5QR52VT
ZlfdHgWXWtZx9nfx+xmOvLc+KQpWctjk17qCng2ZvydMqLgbdk/Xs9HAbRVtW/wD
iK2DF1c8OjJgZ4+QZklQmAwAomxPr2XSTEynGEARiEUv+AAtWAOxRUwWGqkLmCzH
8dTOEmumTxcSgYX8S8liuUr5XeiJtd7DS+x7ApZJPVGkgykdqvMZ0vZP0dNJpWOG
TYXUFmNXDXlupaka+DEb84sl4dWb3qU25zboq53Q+ZJgMBhtWwwUoy46il6JyzeY
TL+iMP4kzOtJEELKBula/cCiGMGlL1+ZziHNFrZbW6fDzUOeHIZTNbOAMAh4p0jF
SwhczIK+fIcz7NVb4Jz5deCUDZ2a1SSctjOWNUQJ2BiQe+TWPJoNZvlHagm9Xh7f
R3aonUCTONwtsMhecBfKdn5bXM2nRnvuCXMMrVWwNUj6loBBVif0rXnEgpN+bkA7
QNxpOXjdlyql+0wvpDYbQ/hT58iCHpzrSoZPb8Uu19+aptJl+Gpe1CbiXs8lEo2y
gTq/XgIhr70q3HN07VbybQAAB0NidS6G88PCXhzqLZ0tOLh34KUqiZGi788hZltN
LVichD0EOeihJ38JZPJ2w2w/TVAyVQZTQNsZdhiOwmt/XTywWYaBW1Wo78A0q6bC
TWOi5fPVs3moSAFHjym9
=RCfE
-----END PGP SIGNATURE-----

--Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DA1D0AF2-C967-47F7-8110-FA91B1E6281B>