From owner-freebsd-scsi@freebsd.org Fri Dec 4 17:04:02 2015 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E419A416B9 for ; Fri, 4 Dec 2015 17:04:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D6D251CF2 for ; Fri, 4 Dec 2015 17:04:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id D4500A416B8; Fri, 4 Dec 2015 17:04:01 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9F8AA416B7 for ; Fri, 4 Dec 2015 17:04:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ob0-x234.google.com (mail-ob0-x234.google.com [IPv6:2607:f8b0:4003:c01::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 745CB1CF1 for ; Fri, 4 Dec 2015 17:04:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by obbnk6 with SMTP id nk6so77601152obb.2 for ; Fri, 04 Dec 2015 09:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=sender:from:content-type:subject:date:message-id:to:mime-version; bh=pL60yGTNe5FH8EABZWIcTVMdbehyihnoIf7sEi4Nqow=; b=l1X0lPKdIhRV8UNW0+ijHXtA5SJTISOBpdkqaCcsqat5+ztsokQQ2PGAAcFc+zBEQD Evb4gApSvDmS2uTvxzZ0CaRSVt4zqgUd3WgkF6hAniLy7epCr653pCo4678HXEVCibfD qz1K2nb0H/cP4dr+jRyW61YwjzlqzajAEQJoh3D8Zc1oPUXrv7XJMJkREQRnIWBFT+Lc gZdGbVyJvtRU9WN+PlB/ITGh16v2ANEvYiELMEHI234dAwq4OMqapve1F7ffsHcgvVnu QQztkKoWKa+kTlQdGuYSlWiBDaGPCsGhpACLqn/Gwis4xWC/ZmYA8Xt17md+4W7VXkmf j8Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:content-type:subject:date:message-id :to:mime-version; bh=pL60yGTNe5FH8EABZWIcTVMdbehyihnoIf7sEi4Nqow=; b=V/BymUw9FSWRDEhEtc3T9BIbGvGrx3LtRdxxhiX728ItExArYBbbdFol2ZmP5xA8iy Hv9VN3A4S3emWBoEm8RF31b8weAZtkVqrtUfytjMOxXgQOnivQCrOf9rq/zutFnXuinI 2Tt/4KE+xzv6xj3DzoyjAgGVCt4krGGFNhufDeR3GTNa2DZlN5UMKvqQeHKRmOynL5K1 zfoInqtCWJ9Oj4TQ62IOLI0gsepMfm90E2akwu8TyUTCiYtSoYbWteIykATzYV0h/q7M whrNuEUorLWb6dklsiLnYW6YaZKekl1NUicPk+yktFU+c8YDzBT8PY8nQcvYJ7EmTCit +SBg== X-Gm-Message-State: ALoCoQnupHqxkT4eJVLYFhhcubLaF/htVPdnezD2tY3El0Ygq+7zThXND8v10ZlEoPXw/6ZjBliI X-Received: by 10.182.28.4 with SMTP id x4mr10019521obg.13.1449248640351; Fri, 04 Dec 2015 09:04:00 -0800 (PST) Received: from ?IPv6:2601:280:4900:3700:4939:59c6:c70c:980e? ([2601:280:4900:3700:4939:59c6:c70c:980e]) by smtp.gmail.com with ESMTPSA id j131sm6174925oib.0.2015.12.04.09.03.59 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Dec 2015 09:03:59 -0800 (PST) Sender: Warner Losh From: Warner Losh X-Pgp-Agent: GPGMail 2.5.2 Content-Type: multipart/signed; boundary="Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790"; protocol="application/pgp-signature"; micalg=pgp-sha512 Subject: Minor improvement in debugging Date: Fri, 4 Dec 2015 10:03:58 -0700 Message-Id: To: scsi@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 17:04:02 -0000 --Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 While writing the NVMe CAM attachment, I noticed that the xpt_action() routine=E2=80=99s logging would be a lot more useful if we logged the = function code. In addition, it is useful to log calls to the SIM inside of xpt_action_default(). Some sims have debugs, others don=E2=80=99t. This review fixes that. https://reviews.freebsd.org/D4382 Warner P.S. I=E2=80=99ll be sending out a bunch of review pointers to this = list. If there=E2=80=99s a more-preferred way to do this, please let me know. --Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWYcd/AAoJEGwc0Sh9sBEAwjQP/iITi2x1+0kqtMQ1s5QR52VT ZlfdHgWXWtZx9nfx+xmOvLc+KQpWctjk17qCng2ZvydMqLgbdk/Xs9HAbRVtW/wD iK2DF1c8OjJgZ4+QZklQmAwAomxPr2XSTEynGEARiEUv+AAtWAOxRUwWGqkLmCzH 8dTOEmumTxcSgYX8S8liuUr5XeiJtd7DS+x7ApZJPVGkgykdqvMZ0vZP0dNJpWOG TYXUFmNXDXlupaka+DEb84sl4dWb3qU25zboq53Q+ZJgMBhtWwwUoy46il6JyzeY TL+iMP4kzOtJEELKBula/cCiGMGlL1+ZziHNFrZbW6fDzUOeHIZTNbOAMAh4p0jF SwhczIK+fIcz7NVb4Jz5deCUDZ2a1SSctjOWNUQJ2BiQe+TWPJoNZvlHagm9Xh7f R3aonUCTONwtsMhecBfKdn5bXM2nRnvuCXMMrVWwNUj6loBBVif0rXnEgpN+bkA7 QNxpOXjdlyql+0wvpDYbQ/hT58iCHpzrSoZPb8Uu19+aptJl+Gpe1CbiXs8lEo2y gTq/XgIhr70q3HN07VbybQAAB0NidS6G88PCXhzqLZ0tOLh34KUqiZGi788hZltN LVichD0EOeihJ38JZPJ2w2w/TVAyVQZTQNsZdhiOwmt/XTywWYaBW1Wo78A0q6bC TWOi5fPVs3moSAFHjym9 =RCfE -----END PGP SIGNATURE----- --Apple-Mail=_7EA0CD9A-0EC4-4974-B5EA-9E0713E99790--