From owner-svn-src-all@freebsd.org Sat May 18 13:00:20 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A407C158A342; Sat, 18 May 2019 13:00:20 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 457D2812E9; Sat, 18 May 2019 13:00:20 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 2ECB6886F; Sat, 18 May 2019 13:00:20 +0000 (UTC) Date: Sat, 18 May 2019 13:00:20 +0000 From: Alexey Dokuchaev To: Allan Jude Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347953 - head/cddl/contrib/opensolaris/cmd/zfs Message-ID: <20190518130020.GA91640@FreeBSD.org> References: <201905181227.x4ICRMsG073717@repo.freebsd.org> <20190518123708.GA73234@FreeBSD.org> <289b3593-421b-44e9-4c0b-d128f8648dcf@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <289b3593-421b-44e9-4c0b-d128f8648dcf@freebsd.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 457D2812E9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.87 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.87)[-0.869,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 May 2019 13:00:20 -0000 On Sat, May 18, 2019 at 04:53:35AM -0400, Allan Jude wrote: > On 5/18/19 8:37 AM, Alexey Dokuchaev wrote: > > On Sat, May 18, 2019 at 12:27:22PM +0000, Allan Jude wrote: > >> New Revision: 347953 > >> URL: https://svnweb.freebsd.org/changeset/base/347953 > >> > >> ... > >> - (void) nvlist_lookup_string(lnvl, propname, > >> - &lvstr); > >> - (void) nvlist_lookup_string(rnvl, propname, > >> - &rvstr); > >> + if ((nvlist_lookup_string(lnvl, propname, > >> + &lvstr) == ENOENT) || > >> + (nvlist_lookup_string(rnvl, propname, > >> + &rvstr) == ENOENT)) { > >> + goto compare_nums; > >> + } > > > > Another thing not to like about ZoL: their completely bogus code style > > and formatting practices (look at those "&rvstr) == ENOENT"). If they > > are going to listen to us, can we at least try to convince them not to > > break existing, much FreeBSD-like formatting? > > They have strict CI that enforces Solaris cstyle, as that is what the > code base has always used. No commit is merged until it passes that, and > many other tests. Hmm, OK then, sorry for the noise. It looked rather bad in the email client, but that's common issue with tabs, I should've checked better. ./danfe