From owner-freebsd-fs@FreeBSD.ORG Sun Nov 28 23:15:43 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85FF91065695 for ; Sun, 28 Nov 2010 23:15:43 +0000 (UTC) (envelope-from etnapierala@googlemail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1188A8FC08 for ; Sun, 28 Nov 2010 23:15:42 +0000 (UTC) Received: by fxm16 with SMTP id 16so2125597fxm.13 for ; Sun, 28 Nov 2010 15:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=oo3J9jO17I4fx5Uz6DlAmmXDW1jsLp7cL9lFhbwHD1c=; b=j0Un4annM8/djw1234hVedF32m94V3SebqVluOJKDqe0U49UAvBPNLqgMRjdTEhWKj oDOQhHZ5NlwMTKJi6/XD2R3PqyU1d0cvw3S3RW+0GKusTg3sCSfbH/MFso635U5KgW98 F5Xv8EqLcxLv7dhRHTRG0ryjYghfr4LxIOUtc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=ghgvadgvDq4vXWcWLYF+9kDY5w8naN3yNRa/jvDtLYPkCLL3i1ZBFkJUT00yAjrWPL EIFZeWukyytjrBtJ0iOxe1Krj6H+uUIa2Yzqoi2ZWGIXn+Ats7F+EPkrRXJP5UTPBpwp 67WuboxYXVAw0+g8tQfaAUffXKn/e/Vn2Nmrk= Received: by 10.223.101.131 with SMTP id c3mr4714822fao.95.1290984799246; Sun, 28 Nov 2010 14:53:19 -0800 (PST) Received: from [192.168.1.102] (45.81.datacomsa.pl [195.34.81.45]) by mx.google.com with ESMTPS id f24sm426995fak.24.2010.11.28.14.53.17 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 28 Nov 2010 14:53:18 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=iso-8859-2 From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= In-Reply-To: <4CF26B15.6090009@jrv.org> Date: Sun, 28 Nov 2010 23:53:13 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <7A3D90B8-EEC0-4FC2-9744-C58379709901@FreeBSD.org> References: <4CF26B15.6090009@jrv.org> To: James R. Van Artsdalen X-Mailer: Apple Mail (2.1082) Cc: freebsd-fs Subject: Re: ZFS panic: empty ZFS ACL X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Nov 2010 23:15:43 -0000 Wiadomo=B6=E6 napisana przez James R. Van Artsdalen w dniu 2010-11-28, o = godz. 15:45: > amd64 > Version String: FreeBSD 9.0-CURRENT #0 r214378M: Sun Nov 28 07:52:25 > CST 2010 root@kraken.housenet.jrv:/usr/obj/usr/src/sys/GENERIC > Panic String: empty ZFS ACL >=20 > I got this panic via "ls -l" after copying in a very old pool via zfs > send/recv: the pool originated on Macintosh ZFS just after Apple first > released the initial build of that. Could you try the patch below? Index: sys/cddl/compat/opensolaris/kern/opensolaris_acl.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/cddl/compat/opensolaris/kern/opensolaris_acl.c (revision = 215553) +++ sys/cddl/compat/opensolaris/kern/opensolaris_acl.c (working copy) @@ -105,7 +105,10 @@ struct acl_entry *entry; const ace_t *ace; =20 - KASSERT(nentries >=3D 1, ("empty ZFS ACL")); + if (nentries < 1) { + printf("acl_from_aces: empty ZFS ACL; returning = EINVAL.\n"); + return (EINVAL); + } =20 if (nentries > ACL_MAX_ENTRIES) { /* -- If you cut off my head, what would I say? Me and my head, or me and my = body?