From owner-cvs-all@FreeBSD.ORG Mon Feb 13 04:47:45 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CD0616A420; Mon, 13 Feb 2006 04:47:45 +0000 (GMT) (envelope-from mux@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C0FA43D46; Mon, 13 Feb 2006 04:47:45 +0000 (GMT) (envelope-from mux@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k1D4ljd2050409; Mon, 13 Feb 2006 04:47:45 GMT (envelope-from mux@repoman.freebsd.org) Received: (from mux@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k1D4ljmN050408; Mon, 13 Feb 2006 04:47:45 GMT (envelope-from mux) Message-Id: <200602130447.k1D4ljmN050408@repoman.freebsd.org> From: Maxime Henrion Date: Mon, 13 Feb 2006 04:47:44 +0000 (UTC) To: projects-committers@FreeBSD.org, cvs-projects@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: projects/csup mux.c mux.h proto.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2006 04:47:45 -0000 mux 2006-02-13 04:47:44 UTC FreeBSD projects repository Modified files: csup mux.c mux.h proto.c Log: Retire chan_wait(). For all I can see, CVSup is not waiting for the server to acknowledge the closing of the channels, and it can cause hangs waiting for a signal that is never going to be delivered, if the multiplexer has already been closed because of an error. I'll have to check this more carefully, but in the meantime this will do. If needed this function can be reintroduced without the race, and I'll need to remember errors in channels anyways. Revision Changes Path 1.63 +1 -11 projects/csup/mux.c 1.22 +1 -2 projects/csup/mux.h 1.66 +1 -3 projects/csup/proto.c