From nobody Fri May 1 05:53:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g6Kvl4T7Qz6bvCp for ; Fri, 01 May 2026 05:53:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g6Kvl3n7xz3QvP for ; Fri, 01 May 2026 05:53:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777614787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nXGPde0VMbm6Wxmdu5iqNniId7PmquCWY7Ywe6YZMCU=; b=IPC4gEWZm95NC4EW4nv+RTqkOmAIh0RGnnwjGtrRC5rZJZgdIgLC5KULYzfwT/I3qcSs82 /uNuNOxR+E0R+Ju/7Z0+GDoYquAvhsAydRRUl2WvEEIZuc9kJ2GamXZ7f7dDFtyhLuTYqL AdthJH2r5XakOCioViSRtb4suv1V4wfJ7xJBqHdHcJbjq75K9V2Td30NT5dhMHbSg1HLjI faU63pEVeD7BsQyoyE649yzzkhld6zVJp/xYE2AzGwMch75w7vqlyLk+FyVRm9lJrZ51SX e0Li78d0ejT+kSxue9SFPk9TwVgMQKW0EqXml9rIYUWpqHH4mOprLxoAdfK7eQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777614787; a=rsa-sha256; cv=none; b=nRl7D7y25zMgKejw3pFrKgGUAR7REILSd4+zUQGXH3C/zOKLN6sV6ErgHCH+Y7Yl2Codls a4BPnssvvALXxpQfo/pSpXKFL1tqmT7IBbxvZio36OmAKxHS+8ta/0sB2dedhGKqjt8qkV Y/rOpPBTsDt4Q+uNZREn2VgYBIAQchoGYrc3YqO/OtjNLiFwozlxG5KK+pCBQ7eFT2GkAX ey66U9b4GIptF65eCrJQUrceyHDuZ3XdFMqKh5PSOzhuo3nkztr/aAnEXbgARZoIcrvo7t 7BWe49HTu/I1U2G0v/gayRkZ/l002isnD2cnMyGz50LAN0ohkANJPBzqL81Rtw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777614787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nXGPde0VMbm6Wxmdu5iqNniId7PmquCWY7Ywe6YZMCU=; b=YBPqWlX1CBOa3fQfWDjB75s+JTLPW5KiKOECQUTOR98TZ7yiraF5+AfVRYlebJZNWZb5o6 4kzIDbe+XB4Zb+UlcTyGbVCXWCOUHsLZ13K05qbGBbfrmSx4Cjw5W2dGobgF887D8OR5jH iMVMotRlTSzcml97wo82f2IkPcJzhFH2qKJxyETUxoEgo5Xz1laGyM6WpLlVFzrM4hk4U1 LWZ3uggSPlWyKgHzrAbdMPpoKdmyYwoc26jZdigMeDvQwFpntJ9jaM3BOP7IcawPN0XL2B La9xSk9uwjpR5BCwXT2F1q0HwXTm7Ed6gTSbGrvRB+j4/rDAJw5e/+I5SGkzfg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g6Kvl3NvYzmLm for ; Fri, 01 May 2026 05:53:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26a88 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 01 May 2026 05:53:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Johan=?utf-8?Q? S=C3=B6llv?=ander Subject: git: 0baae6223a63 - stable/15 - ctld: normalize iSCSI TargetName on login List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: js X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 0baae6223a6350215d7b11264e59408362b15a19 Auto-Submitted: auto-generated Date: Fri, 01 May 2026 05:53:02 +0000 Message-Id: <69f43fbe.26a88.4ef1de60@gitrepo.freebsd.org> The branch stable/15 has been updated by js: URL: https://cgit.FreeBSD.org/src/commit/?id=0baae6223a6350215d7b11264e59408362b15a19 commit 0baae6223a6350215d7b11264e59408362b15a19 Author: Johan Söllvander AuthorDate: 2026-04-24 07:44:43 +0000 Commit: Johan Söllvander CommitDate: 2026-05-01 05:52:40 +0000 ctld: normalize iSCSI TargetName on login Case-insensitive TargetName matching on logins was accidentally removed, let's fix that by normalizing TargetName again according to RFC 3722. PR: 294522 Fixes: 4b1aac931465f39c5c26bfa1d5539a428d340f20 Sponsored by: ConnectWise Reviewed by: asomers, jhb Approved by: asomers (mentor) Differential Revision: https://reviews.freebsd.org/D56469 (cherry picked from commit eb837cb8b2073c09bafaf3318f5bb103827b2bca) --- usr.sbin/ctld/login.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ctld/login.cc b/usr.sbin/ctld/login.cc index cda11cc1f21b..fb4b60c37f54 100644 --- a/usr.sbin/ctld/login.cc +++ b/usr.sbin/ctld/login.cc @@ -967,12 +967,18 @@ iscsi_connection::login() login_send_error(request, 0x02, 0x07); log_errx(1, "received Login PDU without TargetName"); } + /* + * Normalize target_name according to RFC 3722 + */ + std::string t_name(target_name); + for (char &c : t_name) + c = tolower(c); - conn_port = pg->find_port(target_name); + conn_port = pg->find_port(t_name); if (conn_port == NULL) { login_send_error(request, 0x02, 0x03); log_errx(1, "requested target \"%s\" not found", - target_name); + t_name.c_str()); } conn_target = conn_port->target(); }