From owner-freebsd-arch@FreeBSD.ORG Wed Apr 2 18:17:46 2008 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 371D71065786 for ; Wed, 2 Apr 2008 18:17:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 22EF78FC24 for ; Wed, 2 Apr 2008 18:17:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id CFE8F1A4D80; Wed, 2 Apr 2008 11:17:45 -0700 (PDT) From: John Baldwin To: freebsd-arch@freebsd.org Date: Wed, 2 Apr 2008 13:09:54 -0400 User-Agent: KMail/1.9.7 References: <10004.1205307334@critter.freebsd.dk> <20080312152744.I29518@fledge.watson.org> <20080328202602.N72156@desktop> In-Reply-To: <20080328202602.N72156@desktop> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804021309.54956.jhb@freebsd.org> Cc: Subject: Re: timeout/callout small step forward X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2008 18:17:46 -0000 On Saturday 29 March 2008 03:04:17 am Jeff Roberson wrote: > http://people.freebsd.org/~jeff/callout.diff > > This patch takes the current callout implementation and makes it per-cpu. > It also hides callout details from the rest of the kernel by making the > callwheel structure private to kern_timeout.c among other things. Looks good. The kern_intr.c diff has a small bug (forgot to remove the return (intr_event_create(...)) from swi_add()). A few style suggestions would be to always leave a blank line before a comment (I think I saw this in kern_calloutwheel_init()?) and usually there isn't a blank line before a SYSINIT(). Maybe make the panic messages when creating softclock threads more specific, but that's very minor. -- John Baldwin