Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 7 Jul 2015 12:37:47 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org>
Subject:   Re: CFT/CFR: NUMA policy branch
Message-ID:  <20150707093747.GE2080@kib.kiev.ua>
In-Reply-To: <CAJ-Vmo=ON9bEngDoMFK-kJR=qVvcX%2BEeQXx%2BUoEsh1npMHjESQ@mail.gmail.com>
References:  <CAJ-Vmo=SnqXTF5m65haKqrVf699zinyXs%2BQdvR6V88CW7vooCw@mail.gmail.com> <CAJ-VmonyTfSxj%2BD=FN3TUCO33w4vGqh1REQqx-8rd-JcArfqSA@mail.gmail.com> <CAJ-Vmo=ON9bEngDoMFK-kJR=qVvcX%2BEeQXx%2BUoEsh1npMHjESQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 05, 2015 at 07:06:27PM -0700, Adrian Chadd wrote:
> Hi,
> 
> I've done another update. kib@ has been beating me with the clue stick a bit.
> 
> https://github.com/freebsd/freebsd/compare/master...erikarn:local/adrian_numa_policy
> 
> * (kib) (numactl.c) fix up sorting of include files
> * (kib) (numactl.c) consistent use of values when calling err()
> * (kib) (numactl.c) consistently wrap lines at 78 characters, don't
> prematurely wrap lines
> * (kib) don't use the old-style BSD licence mentioning "regents", use
> the updated one
> * (kib) (vm_domain.c) don't break out after iterating a few times and
> have the API be unpredictable - so now the API will always succeed in
> reading a vm_policy
> 
> I've tested the policies (first-touch, fixed-domain, round-robin) and
> they all still work as advertised, both on threads and processes.
> 
> I'd appreciate more reviews and some further testing.

I did not found a fix for the wrong locking of seq_t.
Am I reading sys_numa_getaffinity() right that it does copyout() while
owning the process lock ?
The things are still syscalls instead of procctl() commands.

I did not read further, the patch is half-done at best.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150707093747.GE2080>