From owner-freebsd-arch@freebsd.org  Tue Jul  7 09:38:00 2015
Return-Path: <owner-freebsd-arch@freebsd.org>
Delivered-To: freebsd-arch@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC8954C87B
 for <freebsd-arch@mailman.ysv.freebsd.org>;
 Tue,  7 Jul 2015 09:38:00 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5498B1FEA;
 Tue,  7 Jul 2015 09:38:00 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t679blsh066509
 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Tue, 7 Jul 2015 12:37:47 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t679blsh066509
Received: (from kostik@localhost)
 by tom.home (8.14.9/8.14.9/Submit) id t679blPn066508;
 Tue, 7 Jul 2015 12:37:47 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Tue, 7 Jul 2015 12:37:47 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Adrian Chadd <adrian@freebsd.org>
Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org>
Subject: Re: CFT/CFR: NUMA policy branch
Message-ID: <20150707093747.GE2080@kib.kiev.ua>
References: <CAJ-Vmo=SnqXTF5m65haKqrVf699zinyXs+QdvR6V88CW7vooCw@mail.gmail.com>
 <CAJ-VmonyTfSxj+D=FN3TUCO33w4vGqh1REQqx-8rd-JcArfqSA@mail.gmail.com>
 <CAJ-Vmo=ON9bEngDoMFK-kJR=qVvcX+EeQXx+UoEsh1npMHjESQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJ-Vmo=ON9bEngDoMFK-kJR=qVvcX+EeQXx+UoEsh1npMHjESQ@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jul 2015 09:38:01 -0000

On Sun, Jul 05, 2015 at 07:06:27PM -0700, Adrian Chadd wrote:
> Hi,
> 
> I've done another update. kib@ has been beating me with the clue stick a bit.
> 
> https://github.com/freebsd/freebsd/compare/master...erikarn:local/adrian_numa_policy
> 
> * (kib) (numactl.c) fix up sorting of include files
> * (kib) (numactl.c) consistent use of values when calling err()
> * (kib) (numactl.c) consistently wrap lines at 78 characters, don't
> prematurely wrap lines
> * (kib) don't use the old-style BSD licence mentioning "regents", use
> the updated one
> * (kib) (vm_domain.c) don't break out after iterating a few times and
> have the API be unpredictable - so now the API will always succeed in
> reading a vm_policy
> 
> I've tested the policies (first-touch, fixed-domain, round-robin) and
> they all still work as advertised, both on threads and processes.
> 
> I'd appreciate more reviews and some further testing.

I did not found a fix for the wrong locking of seq_t.
Am I reading sys_numa_getaffinity() right that it does copyout() while
owning the process lock ?
The things are still syscalls instead of procctl() commands.

I did not read further, the patch is half-done at best.