From owner-freebsd-net@FreeBSD.ORG  Fri Apr 20 16:03:52 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8A25916A406
	for <freebsd-net@freebsd.org>; Fri, 20 Apr 2007 16:03:52 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outR.internet-mail-service.net (outR.internet-mail-service.net
	[216.240.47.241])
	by mx1.freebsd.org (Postfix) with ESMTP id 7771113C44C
	for <freebsd-net@freebsd.org>; Fri, 20 Apr 2007 16:03:52 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160)
	by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP;
	Fri, 20 Apr 2007 08:31:50 -0700
Received: from [192.168.2.3] (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id 2BC56125AE1;
	Fri, 20 Apr 2007 09:03:51 -0700 (PDT)
Message-ID: <4628E470.1080207@elischer.org>
Date: Fri, 20 Apr 2007 09:04:00 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 1.5.0.10 (Macintosh/20070221)
MIME-Version: 1.0
To: Bruce M Simpson <bms@incunabulum.net>
References: <4628DA3A.3050309@incunabulum.net>
In-Reply-To: <4628DA3A.3050309@incunabulum.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: FreeBSD-Net mailing list <freebsd-net@freebsd.org>
Subject: Re: MFC of ether_input() changes
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2007 16:03:52 -0000

Bruce M Simpson wrote:
> Hi,
> 
> Does anyone want to see these changes MFCed, or otherwise object to such 
> an MFC?
> The introduction of M_PROMISC did the following:
> 
>   * Drop frames immediately if the interface is not marked IFF_UP.

ok

>   * Always trim off the frame checksum if present.
>   * Always use M_VLANTAG in preference to passing 802.1Q frames
>     to consumers.

ok, though I may have to change production code (or at least retest it)

>   * Use __func__ consistently for KASSERT().

ok

>   * Use the M_PROMISC flag to detect situations where ether_input()
>     may reenter itself on the same call graph with the same mbuf which
>     was promiscuously received on behalf of subsystems such as
>     netgraph, carp, and vlan.

ok

>   * 802.1P frames (that is, VLAN frames with an ID of 0) will now be
>     passed to layer 3 input paths.

>   * Deal with the special case for CARP in a sane way.

I don't  use CARP

> 
> For end users the main change of interest will be the ability for 
> FreeBSD to receive 802.1p frames, even if it doesn't do anything with 
> the priority fields right now.
> 
> If I hear 'yeses' I will try to MFC this as time permits.

OK by me, but I defer to anyone who says no..
> 
> Regards,
> BMS
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"