From owner-cvs-etc  Tue Jul 30 00:47:31 1996
Return-Path: owner-cvs-etc
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id AAA27598
          for cvs-etc-outgoing; Tue, 30 Jul 1996 00:47:31 -0700 (PDT)
Received: from time.cdrom.com (time.cdrom.com [204.216.27.226])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA27581;
          Tue, 30 Jul 1996 00:47:24 -0700 (PDT)
Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.5/8.6.9) with ESMTP id AAA11799; Tue, 30 Jul 1996 00:46:45 -0700 (PDT)
To: Bruce Evans <bde@zeta.org.au>
Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-etc@freefall.freebsd.org
Subject: Re: cvs commit: src/etc rc 
In-reply-to: Your message of "Tue, 30 Jul 1996 17:20:46 +1000."
             <199607300720.RAA07220@godzilla.zeta.org.au> 
Date: Tue, 30 Jul 1996 00:46:45 -0700
Message-ID: <11797.838712805@time.cdrom.com>
From: "Jordan K. Hubbard" <jkh@time.cdrom.com>
Sender: owner-cvs-etc@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Well, I certainly wasn't setting out to right all of sysinstall's
wrongs, just that one submission. ;) If anyone's interested in going
on a cleanup rampage in there, please, be my most welcome guest! :-)

					Jordan

> >  Modified:    etc       rc
> >  Log:
> >  Edit this for consistency's sake (though it's syntactically identical).
> >  Noticed-By: "William A. Gill" <bill@duchess.wagill.com>
> >  
> >  Revision  Changes    Path
> >  1.96      +2 -2      src/etc/rc
> 
> There are many more inconsistencies in sysconfig.  NO is sometimes quoted
> and sometimes not.  Mostly not.  Quoting it mainly wastes space.
> 
> Also, in rc, some (poor) comments say that the test is $foo != NO, but
> the test is actually "X${foo}" != X"NO".  The braces mainly waste space.
> Other (poor) comments say that the test is $foo == NO for the reverse
> condition, but == isn't an operator for `test'.
> 
> Bruce