From owner-freebsd-ipfw  Mon May 28  3:40:42 2001
Delivered-To: freebsd-ipfw@freebsd.org
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65])
	by hub.freebsd.org (Postfix) with ESMTP
	id 29AB437B423; Mon, 28 May 2001 03:40:24 -0700 (PDT)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f4SAeKD25730;
	Mon, 28 May 2001 13:40:20 +0300 (EEST)
	(envelope-from ru)
Date: Mon, 28 May 2001 13:40:20 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Matt Dillon <dillon@FreeBSD.org>
Cc: doc@FreeBSD.org, ipfw@FreeBSD.org
Subject: Re: cvs commit: src/share/man/man7 firewall.7 tuning.7 Makefile
Message-ID: <20010528134020.A6209@sunbay.com>
Mail-Followup-To: Matt Dillon <dillon@FreeBSD.org>, doc@FreeBSD.org,
	ipfw@FreeBSD.org
References: <200105272314.f4RNERG18768@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200105272314.f4RNERG18768@freefall.freebsd.org>; from dillon@FreeBSD.org on Sun, May 27, 2001 at 04:14:27PM -0700
Sender: owner-freebsd-ipfw@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ipfw.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-ipfw>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-ipfw>
X-Loop: FreeBSD.ORG

[Redirected to -doc and -ipfw]

On Sun, May 27, 2001 at 04:14:27PM -0700, Matt Dillon wrote:
> dillon      2001/05/27 16:14:27 PDT
> 
>   Modified files:
>     share/man/man7       Makefile 
>   Added files:
>     share/man/man7       firewall.7 tuning.7 
>   Log:
>   Add two new manual pages related to general firewall and tuning issues
>   
>   Reviewed by: hackers
>   
>   Revision  Changes    Path
>   1.15      +2 -2      src/share/man/man7/Makefile
> 
Sorry, I somehow missed your review request on -hackers, and didn't see
it on the -ipfw list as well.

First, please sort the MAN= entries in Makefile as they were before.

I am somewhat confused as to why you have chosen to add the new
firewall(7) manpage rather than to extend the existing manpages?
IMHO this only creates unnecessary bloat.

For example, the `IPFW KERNEL CONFIGURATION' section is an (almost)
duplicate of the `Kernel Options' in ipfirewall(4) (the latter is
seriously outdated), and it is now required to keep both in sync.
The rest of the firewall(7) manpage fits nicely into the existing
ipfw(8) manpage.

More on makrup later...


Cheers,
-- 
Ruslan Ermilov		Oracle Developer/DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ipfw" in the body of the message