From owner-freebsd-python@freebsd.org Sun Aug 20 07:38:56 2017 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71C0ADE544C for ; Sun, 20 Aug 2017 07:38:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 497627762E for ; Sun, 20 Aug 2017 07:38:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 45ADADE5449; Sun, 20 Aug 2017 07:38:56 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 44E99DE5448; Sun, 20 Aug 2017 07:38:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 102B87762D; Sun, 20 Aug 2017 07:38:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg0-x243.google.com with SMTP id 83so19698646pgb.4; Sun, 20 Aug 2017 00:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5Z8wvXtwUaBJPCyxKCfAIyat1v8mJff7JLVW7/pft54=; b=Vd8Ihsejhmui5s+W80qrVwOR5qAbA+6SG1vxez6CtWOX7gKQEdvS75bSzUPi+CGF+9 AeVavpIVxQCZ7PDweiidE5jqpaJxq07WZN6EXeMLiiIUAP2dV7dNjE+wCG9WN9gqyQl8 7tGT5smo6YLf8ZPoCuHhE3De3JsPUd28UJifP7izcGDp0HrHMYcKj+NLu9TolOhG4RZT e1DS7oYVsQrgKPZW0xAko7xUlecsUmB1GEoZ6d4FYCXqAcQQnxh2E9EErx1yIIPUX/H/ B4AiupH4SGdEhAIV72nrsYMuD3bAEPz3WSmXebs6sbKSdjRMdxcA/8qP8zZM0cfmLGkr ayjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from:cc :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5Z8wvXtwUaBJPCyxKCfAIyat1v8mJff7JLVW7/pft54=; b=hFH4IFwXaSuN35HF9AgPcMNyQEURxNxd8+QK3TGlp01oeCL3uXIjWFl6osAOD994ot vLkevILMPj2r2hE10ZSe7yIUaHz4woSn+9M2frnDP0BCZqcSqRgLd1SMsHwLYM74ncAR yom9uQ6+ihbdVkRvAxv9GYaz76ROfnQ6wyqQAkMxxCx+YJ76BKrdfuXK8f9Xqpr4vOdR AbxkNjzZuLGad1iOMLPw+A33PZdfRyqC3/1GEjWBfW7RPEF4nu7OE0aXfOzDIUDn8PUj U+H2sRo4yYQ0+ugPGnzgy2eymGHPsnLXgi+7T6zz4oyUqXgiIY9pgI4c5EvafFD2eLAO ExtA== X-Gm-Message-State: AHYfb5hrvuC06nh4lSJvCain7Z0xQbmxhzFKmbuORh2X54XQoZbdz+fe bps/+9+P2PLxgqKYhos= X-Received: by 10.84.241.136 with SMTP id b8mr12261134pll.361.1503214734846; Sun, 20 Aug 2017 00:38:54 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:584:283a:c57e:de2a? (2001-44b8-31ae-7b01-0584-283a-c57e-de2a.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:584:283a:c57e:de2a]) by smtp.gmail.com with ESMTPSA id a22sm15502131pfj.94.2017.08.20.00.38.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Aug 2017 00:38:54 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r448347 - in head/audio: . py-jack py-jack/files To: Richard Gallamore , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201708191751.v7JHpKbC045997@repo.freebsd.org> From: Kubilay Kocak Cc: Matthew Seaman , python Message-ID: <93360657-5960-68a6-806b-ea18d00970b3@FreeBSD.org> Date: Sun, 20 Aug 2017 17:33:13 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: <201708191751.v7JHpKbC045997@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Aug 2017 07:38:56 -0000 On 8/20/17 3:51 AM, Richard Gallamore wrote: > Author: ultima > Date: Sat Aug 19 17:51:20 2017 > New Revision: 448347 > URL: https://svnweb.freebsd.org/changeset/ports/448347 > > Log: > PyJack is a module written in C which exposes the Jack API to Python. > For information about Jack see http://jackit.sourceforge.net. This > enables a Python program to connect to and interact with pro-audio > applications which use the Jack Audio Server. > > WWW: https://pypi.python.org/pypi/py-jack > > PR: 220990 > Submitted by: Yuri Victorovich (maintainer) > Reviewed by: matthew (mentor) > Approved by: matthew (mentor) > Differential Revision: https://reviews.freebsd.org/D12079 Hi Richard, This port is incorrectly named, please rename/move it. [1] It conflicts with the PyPI package named 'jack' [2]. Additionally, while upstream refers to it as 'PyJack' in its descriptions, it is also *not* the PyPI 'pyjack' package [3]. The use of DISTNAME in python ports is often a give-away that the PORTNAME is incorrect. Exceptions to the above rule-of-thumb/hint is if the distribution file is not the same as the package name (a small number of authors do this). [1] https://wiki.freebsd.org/Python/PortsPolicy [2] https://pypi.python.org/pypi/jack/ [3] https://pypi.python.org/pypi/pyjack/ > Added: > head/audio/py-jack/ > head/audio/py-jack/Makefile (contents, props changed) > head/audio/py-jack/distinfo (contents, props changed) > head/audio/py-jack/files/ > head/audio/py-jack/files/patch-pyjack.c (contents, props changed) > head/audio/py-jack/pkg-descr (contents, props changed) > Modified: > head/audio/Makefile > > Modified: head/audio/Makefile > ============================================================================== > --- head/audio/Makefile Sat Aug 19 17:49:43 2017 (r448346) > +++ head/audio/Makefile Sat Aug 19 17:51:20 2017 (r448347) > @@ -648,6 +648,7 @@ > SUBDIR += py-gmusicproxy > SUBDIR += py-hsaudiotag > SUBDIR += py-id3 > + SUBDIR += py-jack > SUBDIR += py-karaoke > SUBDIR += py-mad > SUBDIR += py-mpd > > Added: head/audio/py-jack/Makefile > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/audio/py-jack/Makefile Sat Aug 19 17:51:20 2017 (r448347) > @@ -0,0 +1,31 @@ > +# Created by: Yuri Victorovich > +# $FreeBSD$ > + > +PORTNAME= jack > +PORTVERSION= 0.5.2 > +CATEGORIES= audio python > +MASTER_SITES= CHEESESHOP > +PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} > +DISTNAME= py-${PORTNAME}-${PORTVERSION} > + > +MAINTAINER= yuri@rawbw.com > +COMMENT= PyJack is a Python bindings for the Jack Audio Server Strip 'PyJack is a ' > +LICENSE= GPLv2 > + > +LIB_DEPENDS= libjack.so:audio/jack > +BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}numpy>0:math/py-numpy > + > +USES= python:-2.7 localbase > +USE_PYTHON= distutils autoplist > + > +post-patch: > + @${REINPLACE_CMD} -e \ > + 's|"/usr/local/|"${LOCALBASE}/|; \ > + s|"jack", "dl"|"jack"|; \ > + s|os.system.*|pass|' \ > + ${WRKSRC}/setup.py > +post-install: > + @${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/jack.so > + > +.include > > Added: head/audio/py-jack/distinfo > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/audio/py-jack/distinfo Sat Aug 19 17:51:20 2017 (r448347) > @@ -0,0 +1,3 @@ > +TIMESTAMP = 1500938413 > +SHA256 (py-jack-0.5.2.tar.gz) = 67951f7b78ded52f3191a5267cd917f1270a6abe28341ccb3575bdd482488590 > +SIZE (py-jack-0.5.2.tar.gz) = 13490 > > Added: head/audio/py-jack/files/patch-pyjack.c > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/audio/py-jack/files/patch-pyjack.c Sat Aug 19 17:51:20 2017 (r448347) > @@ -0,0 +1,10 @@ > +--- pyjack.c.orig 2017-07-24 23:24:04 UTC > ++++ pyjack.c > +@@ -40,7 +40,6 @@ TODO's: > + // Global shared data for jack > + > + /* Uncomment the next line if you have Jack2 */ > +-#define JACK2 1 > + > + > + #define PYJACK_MAX_PORTS 256 > > Added: head/audio/py-jack/pkg-descr > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/audio/py-jack/pkg-descr Sat Aug 19 17:51:20 2017 (r448347) > @@ -0,0 +1,6 @@ > +PyJack is a module written in C which exposes the Jack API to Python. > +For information about Jack see http://jackit.sourceforge.net. This > +enables a Python program to connect to and interact with pro-audio > +applications which use the Jack Audio Server. > + > +WWW: https://pypi.python.org/pypi/py-jack >