From owner-cvs-all Mon Nov 27 22:20:53 2000 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 295D737B400; Mon, 27 Nov 2000 22:20:49 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.0/8.11.0) with ESMTP id eAS6KlQ59392; Mon, 27 Nov 2000 23:20:48 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id XAA07951; Mon, 27 Nov 2000 23:20:47 -0700 (MST) Message-Id: <200011280620.XAA07951@harmony.village.org> To: Alfred Perlstein Subject: Re: cvs commit: src/usr.sbin/inetd builtins.c Cc: "Brian F. Feldman" , obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Mon, 27 Nov 2000 22:15:35 PST." <20001127221535.Y8051@fw.wintelcom.net> References: <20001127221535.Y8051@fw.wintelcom.net> <20001126182240.A8051@fw.wintelcom.net> <200011262140.eAQLe2576200@green.dyndns.org> <20001126182240.A8051@fw.wintelcom.net> <200011280524.WAA07413@harmony.village.org> Date: Mon, 27 Nov 2000 23:20:47 -0700 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20001127221535.Y8051@fw.wintelcom.net> Alfred Perlstein writes: : * Warner Losh [001127 21:24] wrote: : > In message <20001126182240.A8051@fw.wintelcom.net> Alfred Perlstein writes: : > : - if ((to.tv_usec += tv.tv_usec) >= 1000000) { : > : + to.tv_usec += tv.tv_usec; : > : + if (to.tv_usec >= 1000000) { : > : to.tv_usec -= 1000000; : > : to.tv_sec++; : > : } : > : > Shouldn't this be : > if (to.tv_usec >= 1000000) { : > to.tv_sec += to.tv_usec / 1000000; : > to.tv_usec %= 1000000; : > } : : Yes, but it's overkill as afaik to.tv_usec >= 2000000 : shouldn't happen. I missed that we were adding two normalized tv, so forget I said anything. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message