From owner-freebsd-ports-bugs@FreeBSD.ORG Sat May 24 09:40:00 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BD58FEE8 for ; Sat, 24 May 2014 09:40:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 958342BB1 for ; Sat, 24 May 2014 09:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s4O9e0wO078050 for ; Sat, 24 May 2014 09:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s4O9e0V7078049; Sat, 24 May 2014 09:40:00 GMT (envelope-from gnats) Resent-Date: Sat, 24 May 2014 09:40:00 GMT Resent-Message-Id: <201405240940.s4O9e0V7078049@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Harald Schmalzbauer Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 66151E64 for ; Sat, 24 May 2014 09:31:58 +0000 (UTC) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CEAA72B6C for ; Sat, 24 May 2014 09:31:57 +0000 (UTC) Received: from gune.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id s4O9VsUq035676 for ; Sat, 24 May 2014 11:31:54 +0200 (CEST) (envelope-from admin@preed.egn.mo1.omnilan.net) Received: from preed.egn.mo1.omnilan.net (preed.egn.mo1.omnilan.net [IPv6:2001:a60:f0bb:2::3:1]) by gune.mo1.omnilan.net (8.14.7/8.14.7) with ESMTP id s4O9Vsja006402 for ; Sat, 24 May 2014 11:31:54 +0200 (CEST) (envelope-from admin@preed.egn.mo1.omnilan.net) Received: (from admin@localhost) by preed.egn.mo1.omnilan.net (8.14.7/8.14.7/Submit) id s4O9Vnd0026255; Sat, 24 May 2014 11:31:49 +0200 (CEST) (envelope-from admin) Message-Id: <201405240931.s4O9Vnd0026255@preed.egn.mo1.omnilan.net> Date: Sat, 24 May 2014 11:31:49 +0200 (CEST) From: Harald Schmalzbauer To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/190166: samba41 rc script doesn't follow custom smb.conf X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 May 2014 09:40:00 -0000 >Number: 190166 >Category: ports >Synopsis: samba41 rc script doesn't follow custom smb.conf >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat May 24 09:40:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Harald Schmalzbauer >Release: FreeBSD 9.2-RELEASE-p4+FP2 amd64 >Organization: OmniLAN >Environment: System: FreeBSD preed.egn.mo1.omnilan.net 9.2-RELEASE-p4+FP2 FreeBSD 9.2-RELEASE-p4+FP2 #1: Wed Apr 23 14:25:13 CEST 2014 admin@preed.egn.mo1.omnilan.net:/usr/local/share/deploy-tools/obj-amd64/UNSPEC/usr/local/share/deploy-tools/RELENG_9_2/src/sys/UNSPEC.preed amd64 >Description: When you define a custo smb.conf, the testparm_command silently ignores that file since the parameters are passed wrong, so compile time default will be used. >How-To-Repeat: Define 'samba_server_config="/usr/local/etc/smb_instance1.conf"' in /etc/rc.conf and intentionally include a mistake in custom conf file before starting samba. Samba will start even testparm fisrt should look for mistakes, but it doesn't check the same config file that will be used by the daemons (that part is perfectly working in samba_server.in). >Fix: --- net/samba41/files/samba_server.in 2014-05-09 12:23:44.635424517 +0200 +++ net/samba41/files/samba_server.in 2014-05-19 10:48:54.257114321 +0200 @@ -33,7 +33,7 @@ samba_server_config=${samba_server_config=${samba_server_config_default}} samba_server_configfile_arg=${samba_server_config:+--configfile="${samba_server_config}"} #" #testparm_command="%%PREFIX%%/bin/samba-tool testparm --suppress-prompt --verbose ${samba_server_configfile_arg}" -testparm_command="%%PREFIX%%/bin/testparm --suppress-prompt --verbose ${samba_server_configfile_arg}" +testparm_command="%%PREFIX%%/bin/testparm --suppress-prompt --verbose ${samba_server_config}" smbcontrol_command="%%PREFIX%%/bin/smbcontrol" # Custom commands >Release-Note: >Audit-Trail: >Unformatted: