From owner-dev-commits-src-main@freebsd.org Tue Apr 27 13:53:36 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F2F095F22A4; Tue, 27 Apr 2021 13:53:36 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward100j.mail.yandex.net (forward100j.mail.yandex.net [5.45.198.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FV3Bm57c2z4TCY; Tue, 27 Apr 2021 13:53:35 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward102q.mail.yandex.net (forward102q.mail.yandex.net [IPv6:2a02:6b8:c0e:1ba:0:640:516:4e7d]) by forward100j.mail.yandex.net (Yandex) with ESMTP id 28E6550E2484; Tue, 27 Apr 2021 16:53:24 +0300 (MSK) Received: from vla3-eea282d0d1fe.qloud-c.yandex.net (vla3-eea282d0d1fe.qloud-c.yandex.net [IPv6:2a02:6b8:c15:2583:0:640:eea2:82d0]) by forward102q.mail.yandex.net (Yandex) with ESMTP id 258C93A20010; Tue, 27 Apr 2021 16:53:24 +0300 (MSK) Received: from vla1-cde8305024b9.qloud-c.yandex.net (vla1-cde8305024b9.qloud-c.yandex.net [2a02:6b8:c0d:4201:0:640:cde8:3050]) by vla3-eea282d0d1fe.qloud-c.yandex.net (mxback/Yandex) with ESMTP id Ba0hT1UUwx-rNJGbYDR; Tue, 27 Apr 2021 16:53:24 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1619531604; bh=1CT1McwSf2X6jI1mnGk3IHSdZGt5bi8wJk5fmrl8u9Q=; h=To:In-Reply-To:Subject:Cc:From:Message-Id:References:Date; b=eErcu41NJbuOYPVUZvIckyYTL2h+yWq68N8cc11ZyDgT7ew+qz+6oPpYkxoLimqow koivYwocCxPRynMW6T9LGhwv4daKcH/K2nWMesOg7hdyemefXZqEd7p+yejHDe1TcA OOFNOY7xpW1hNuDsBV8FrOPtwHyr6ob1n0xPWC0E= Received: by vla1-cde8305024b9.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id rqCBBPbG2I-rMLSjeKi; Tue, 27 Apr 2021 16:53:23 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) From: "Alexander V. Chernikov" Message-Id: <2F6FDB4D-37D8-4161-98B1-95BB6AE924C0@ipfw.ru> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: git: 5d1403a79a3e - main - [rtsock] Enforce netmask/RTF_HOST consistency. Date: Tue, 27 Apr 2021 14:53:19 +0100 In-Reply-To: <11556361619526413@vla1-3f9fbb467d83.qloud-c.yandex.net> Cc: Li-Wen Hsu , Kristof Provost , "src-committers@FreeBSD.org" , "dev-commits-src-all@FreeBSD.org" , "dev-commits-src-main@FreeBSD.org" To: "Alexander V. Chernikov" References: <202104242303.13ON3w5l066307@gitrepo.freebsd.org> <11556361619526413@vla1-3f9fbb467d83.qloud-c.yandex.net> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Rspamd-Queue-Id: 4FV3Bm57c2z4TCY X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 13:53:37 -0000 > On 27 Apr 2021, at 13:26, Alexander V. Chernikov = wrote: >=20 > Ack. Interesting. Will look later today. Thank you for bisecting it - = thought the issue was caused by a different change. Looks like there is no more failures in = https://ci.freebsd.org/job/FreeBSD-main-amd64-test/18039/#showFailuresLink= . In fact, I think = https://cgit.freebsd.org/src/commit/?id=3D439d087d0b55574db81f4a2799a411c1= 236d95e3 is the reason. >=20 > -- > Sent from Yandex.Mail for mobile >=20 > 27.04.2021, 12:38, "Kristof Provost" : > On 25 Apr 2021, at 1:03, Alexander V. Chernikov wrote: >=20 > The branch main has been updated by melifaro: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D5d1403a79a3e56403fb63c062252a23f= ce81e5f1 = >=20 > commit 5d1403a79a3e56403fb63c062252a23fce81e5f1 > Author: Alexander V. Chernikov > > AuthorDate: 2021-04-23 21:53:47 +0000 > Commit: Alexander V. Chernikov > > CommitDate: 2021-04-24 22:41:27 +0000 >=20 > [rtsock] Enforce netmask/RTF_HOST consistency. >=20 > Traditionally we had 2 sources of information whether the > added/delete route request targets network or a host route: > netmask (RTA_NETMASK) and RTF_HOST flag. >=20 > The former one is tricky: netmask can be empty or can explicitly > specify the host netmask. Parsing netmask sockaddr requires per-family > parsing and that's what rtsock code traditionally avoided. As a = result, > consistency was not enforced and it was possible to specify network = with > the RTF_HOST flag and vice versa. >=20 > Continue normalization efforts from D29826 and D29826 and ensure that > RTF_HOST flag always reflects host/network data from netmask field. >=20 > Differential Revision: https://reviews.freebsd.org/D29958 = > MFC after: 2 days >=20 > I believe this commit triggers a number of regression test failures: = https://ci.freebsd.org/job/FreeBSD-main-amd64-test/18011/#showFailuresLink= = > The easiest way to reproduce the problem is to kldload ipsec ; cd = /usr/tests/sys/netipsec ; kyua test. > Reverting this patch allows the tests to pass again. (There are a few = others that also fail, but the ipsec tests appear to be the most = reliable way to demonstrate the problem.) >=20 > Best regards, > Kristof >=20