Date: Fri, 3 Apr 2015 16:34:19 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Bartek Rutkowski <robak@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r383138 - head/net-im/uTox Message-ID: <20150403163419.GA39591@FreeBSD.org> In-Reply-To: <551EBCAB.9060803@marino.st> References: <201504031546.t33FkDRj029242@svn.freebsd.org> <20150403160305.GA29223@FreeBSD.org> <551EBCAB.9060803@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 03, 2015 at 06:15:39PM +0200, John Marino wrote: > On 4/3/2015 18:03, Alexey Dokuchaev wrote: > > On Fri, Apr 03, 2015 at 03:46:13PM +0000, Bartek Rutkowski wrote: > >> New Revision: 383138 > >> URL: https://svnweb.freebsd.org/changeset/ports/383138 > >> > >> [...] > >> @@ -23,7 +23,7 @@ USE_GITHUB= yes > >> GH_ACCOUNT= notsecure > >> GH_PROJECT= ${PORTNAME} > >> GH_TAGNAME= ${GH_COMMIT} > >> -GH_COMMIT= f24082d > >> +GH_COMMIT= 15b1ad9 > > > > Bartek, you did read /usr/ports/CHANGES recently about GH_COMMIT (and whole > > new GitHub magic), didn't you? > > What's not clear to me is how long the transition phase from > GITHUB_LEGACY to GITHUB is. It's implied that we should be changing > these from LEGACY to the new URL, but what the ramifications if we don't? > > How long do we have? > 1 month? 1 year? indefinitely? What's the downside of keeping the > original style? Fair question; when I just checked CHANGES prior to my reply, I was kind of expecting to see find "GH_COMMIT is deprecated" along the lines, but right now it reads just that "No GH_COMMIT is needed". However: it seems that GH_COMMIT is indeed not needed in this particular case, and was comitted as is because original submission was not thoroughly reviewed. Another indication is that redundant GH_PROJECT was not removed. That said, I'd like to remind us all once again *not* to apply and commit submitted diffs from the PRs as is, because 1) they might have originated from the old times and thus could not have possibly catch up with changes in the framework, and 2) submitters are not expected to provide 100% good patches in the first place. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150403163419.GA39591>