From owner-freebsd-ports@FreeBSD.ORG Sun Feb 6 10:09:06 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A9F58106566B for ; Sun, 6 Feb 2011 10:09:06 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 35EC18FC0C for ; Sun, 6 Feb 2011 10:09:05 +0000 (UTC) Received: by bwz12 with SMTP id 12so4007123bwz.13 for ; Sun, 06 Feb 2011 02:09:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=S05IKjeSiyCQp4KryfmxpXCxG6lapvZ1vEQr9r6ldFM=; b=QNnIv0/zr4dQIBZFdGXqtypHFtPxQPi3+F494Ql8Au/miU/LM37ytWm0XZwfZH3ybD 4utc7RJMsSTicFoK21LpAeGgpe2+FEf4UoX6uONFo/FjY8//LJtALN1qxzi8OMf3P7Qb oJh/SfRCqu5bJjVENBAgjzDRgesbQaw9DYU+Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:content-type:content-transfer-encoding; b=oUCTNmInfZakMyvmf43LirvL5nXppkgqIqnbgEsYpgZXppZ3WdIwWTd57mv2+NjY6a ivuG54JAnlXwgyDDWND2vnbGtLJxh1EO3QQrA4rt9oNtLtkJ8HZIO742GukZk35xEhEe wVaqOG7f4iDFdhznYO59QpO5PIHirFxtUKlyc= Received: by 10.204.67.204 with SMTP id s12mr3489312bki.196.1296986944585; Sun, 06 Feb 2011 02:09:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.16.142 with HTTP; Sun, 6 Feb 2011 02:08:34 -0800 (PST) In-Reply-To: <8762syroh6.fsf@gmail.com> References: <8762syroh6.fsf@gmail.com> From: Chris Rees Date: Sun, 6 Feb 2011 10:08:34 +0000 Message-ID: To: freebsd-ports@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: Call for testers: projectM comes to FreeBSD! [re ports/152823] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: utisoft@gmail.com List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Feb 2011 10:09:06 -0000 On 6 February 2011 00:33, Raphael Kubo da Costa wrote: > Chris Rees writes: > >> Anyone interested can grab them and test them out! I've tried them on >> i386, they work great; feedback is most welcome. > > In both ports I see that you manually add ${LOCALBASE}/include and > ${LOCALBASE}/lib to CFLAGS. In theory, that shouldn't be necessary. Shouldn't, but unfortunately is! Linking CXX shared library libprojectM_libvisual.so /usr/bin/ld: cannot find -lprojectM *** Error code 1 That also applies to GLEW as below. > > Unfortunately, projectM does not seem to be a very good CMake citizen: > it should have a FindGLEW.cmake file responsible for finding GLEW's > libraries and includes, so that it later can just do something along > these lines: > > =A0include_directories(${GLEW_INCLUDE_DIR}) > =A0target_link_libraries(foo ${GLEW_LIBRARIES}) You're absolutely right, however my cmake-foo is not quite up to that yet, and the authors are _dreadful_ at making releases. I have a feeling this may be the last. > > Also, it shouldn't even have a copy of FindFreetype2.cmake lying around > (which should also render one of the sed's you use in post-path > unnecessary), as CMake itself has had FindFreetype.cmake for quite a > long time. > > Do you know if upstream is aware of these issues? They will soon become aware when I tell them; however I want to make sure it works for us before I start to get them to patch their code. Also, see above. > > Another question related to libprojectM: does it really need to install > Vera.ttf instead of using the system-wide one from > x11-fonts/bitstream-vera? Or is it a different font which happens to > have the same name? I'll investigate. > > As for projectm-libvisual: > > Do you also need to set CFLAGS here too? > > +post-patch: > + =A0 =A0 =A0 @${FIND} ${WRKSRC} -name "*.[hc]*" | ${XARGS} ${REINPLACE_C= MD} \ > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 -e 's# > Is this really needed? It seems to be fairly intrusive. Oh yes it *really* is needed [1]! > > + @${REINPLACE_CMD} -e '/return NULL/d' ${WRKSRC}/actor_projectM.cpp > > Is this one from upstream? If so, isn't it better to put it in files/? No, this is one I made. They've written a dummy function in, but it's type struct * and tries to return NULL. I have a serious hatred of files/patch-*; they break with most updates, they bloat the repository and make it slower for everyone to csup as well. I thought that a ${REINPLACE_CMD} was a cleaner way of doing so. I think I should have made satisfactory (for the time being) replies to these, I will look again at the Vera.ttf. If you think I'm fobbing you off, tell me! Thanks very much for the feedbac= k. Chris [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/154530