From owner-freebsd-bugs Thu Jan 16 19:36:17 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id TAA06980 for bugs-outgoing; Thu, 16 Jan 1997 19:36:17 -0800 (PST) Received: from who.cdrom.com (who.cdrom.com [204.216.27.3]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id TAA06973 for ; Thu, 16 Jan 1997 19:36:14 -0800 (PST) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by who.cdrom.com (8.7.5/8.6.11) with SMTP id TAA02040 for ; Thu, 16 Jan 1997 19:36:01 -0800 (PST) Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id EAA10004; Fri, 17 Jan 1997 04:15:38 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.8.4/8.6.9) id VAA15990; Thu, 16 Jan 1997 21:54:31 +0100 (MET) Message-ID: Date: Thu, 16 Jan 1997 21:54:30 +0100 From: j@uriah.heep.sax.de (J Wunsch) To: thompson@tgsoft.com (mark thompson) Cc: jkh@time.cdrom.com, freebsd-bugs@freefall.freebsd.org Subject: Re: bin/2493: make $DESTDIR work References: <21415.853307483@time.cdrom.com> <199701151334.FAA21208@squirrel.tgsoft.com> X-Mailer: Mutt 0.55-PL10 Mime-Version: 1.0 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199701151334.FAA21208@squirrel.tgsoft.com>; from mark thompson on Jan 15, 1997 05:34:49 -0800 Sender: owner-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As mark thompson wrote: > You will recall that when i raised this whole business week or so ago, > you suggested that whatever patch i had might be more useful as an > example than something to actually use. In the event, some of the > changes are "obviously" ok, and, sadly several are not so obvious. > Furthermore, the games subdirectory still has a problem or two (i know > that there are at least some malloc faux-pas). > I leave it to the judgement of the court. Well, i've only heard one objection, that was: ``Name this thing TARGETDIR.'' What about this? I would kindly ask you to also do one final test: run a ``make release'' (i hope you've got the disk space and the CVS tree for this). This is one of the occasions where ${DESTDIR} is exploitet regularly (perhaps the only occasion in the entire FreeBSD tree). If your changes broke the existing ${DESTDIR} behaviour, this should pop up there. If it doesn't break anything, i see no reason to not include it. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)