From owner-svn-src-head@FreeBSD.ORG Tue May 19 14:08:22 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 499C71065677; Tue, 19 May 2009 14:08:22 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 1E3B98FC1B; Tue, 19 May 2009 14:08:22 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n4JE8LGZ099778; Tue, 19 May 2009 14:08:21 GMT (envelope-from avg@svn.freebsd.org) Received: (from avg@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n4JE8Lxa099777; Tue, 19 May 2009 14:08:21 GMT (envelope-from avg@svn.freebsd.org) Message-Id: <200905191408.n4JE8Lxa099777@svn.freebsd.org> From: Andriy Gapon Date: Tue, 19 May 2009 14:08:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r192379 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2009 14:08:22 -0000 Author: avg Date: Tue May 19 14:08:21 2009 New Revision: 192379 URL: http://svn.freebsd.org/changeset/base/192379 Log: sysctl_rman: report shared resources to devinfo shared uses of a resource are recorded on a sub-list hanging off a main resource object on a main resource list; without this change a shared resource (e.g. irq) is reported only once by devinfo -r/-u; with this change the resource is reported for each driver that allocates it (which is even more than what vmstat -i -a reports). Approved by: jhb (mentor) Modified: head/sys/kern/subr_rman.c Modified: head/sys/kern/subr_rman.c ============================================================================== --- head/sys/kern/subr_rman.c Tue May 19 14:01:57 2009 (r192378) +++ head/sys/kern/subr_rman.c Tue May 19 14:08:21 2009 (r192379) @@ -835,6 +835,7 @@ sysctl_rman(SYSCTL_HANDLER_ARGS) int rman_idx, res_idx; struct rman *rm; struct resource_i *res; + struct resource_i *sres; struct u_rman urm; struct u_resource ures; int error; @@ -881,35 +882,44 @@ sysctl_rman(SYSCTL_HANDLER_ARGS) */ mtx_lock(rm->rm_mtx); TAILQ_FOREACH(res, &rm->rm_list, r_link) { - if (res_idx-- == 0) { - bzero(&ures, sizeof(ures)); - ures.r_handle = (uintptr_t)res; - ures.r_parent = (uintptr_t)res->r_rm; - ures.r_device = (uintptr_t)res->r_dev; - if (res->r_dev != NULL) { - if (device_get_name(res->r_dev) != NULL) { - snprintf(ures.r_devname, RM_TEXTLEN, - "%s%d", - device_get_name(res->r_dev), - device_get_unit(res->r_dev)); - } else { - strlcpy(ures.r_devname, "nomatch", - RM_TEXTLEN); + if (res->r_sharehead != NULL) { + LIST_FOREACH(sres, res->r_sharehead, r_sharelink) + if (res_idx-- == 0) { + res = sres; + goto found; } - } else { - ures.r_devname[0] = '\0'; - } - ures.r_start = res->r_start; - ures.r_size = res->r_end - res->r_start + 1; - ures.r_flags = res->r_flags; - - mtx_unlock(rm->rm_mtx); - error = SYSCTL_OUT(req, &ures, sizeof(ures)); - return (error); } + else if (res_idx-- == 0) + goto found; } mtx_unlock(rm->rm_mtx); return (ENOENT); + +found: + bzero(&ures, sizeof(ures)); + ures.r_handle = (uintptr_t)res; + ures.r_parent = (uintptr_t)res->r_rm; + ures.r_device = (uintptr_t)res->r_dev; + if (res->r_dev != NULL) { + if (device_get_name(res->r_dev) != NULL) { + snprintf(ures.r_devname, RM_TEXTLEN, + "%s%d", + device_get_name(res->r_dev), + device_get_unit(res->r_dev)); + } else { + strlcpy(ures.r_devname, "nomatch", + RM_TEXTLEN); + } + } else { + ures.r_devname[0] = '\0'; + } + ures.r_start = res->r_start; + ures.r_size = res->r_end - res->r_start + 1; + ures.r_flags = res->r_flags; + + mtx_unlock(rm->rm_mtx); + error = SYSCTL_OUT(req, &ures, sizeof(ures)); + return (error); } SYSCTL_NODE(_hw_bus, OID_AUTO, rman, CTLFLAG_RD, sysctl_rman,