From owner-cvs-all Mon Nov 1 15: 3:25 1999 Delivered-To: cvs-all@freebsd.org Received: from server.baldwin.cx (jobaldwi.campus.vt.edu [198.82.67.146]) by hub.freebsd.org (Postfix) with ESMTP id 24C0A14EF0; Mon, 1 Nov 1999 15:03:08 -0800 (PST) (envelope-from jobaldwi@vt.edu) Received: from john.baldwin.cx (john [10.0.0.2]) by server.baldwin.cx (8.9.3/8.9.3) with ESMTP id SAA95938; Mon, 1 Nov 1999 18:02:51 -0500 (EST) (envelope-from jobaldwi@vt.edu) Message-Id: <199911012302.SAA95938@server.baldwin.cx> X-Mailer: XFMail 1.3.1 [p0] on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <199911011727.JAA40199@gndrsh.dnsmgr.net> Date: Mon, 01 Nov 1999 18:02:51 -0500 (EST) From: John Baldwin To: "Rodney W. Grimes" Subject: Re: cvs commit: src/usr.sbin/mergemaster Makefile mergemaster Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, (Chris Costello) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On 01-Nov-99 Rodney W. Grimes wrote: >> chris 1999/10/31 20:29:06 PST >> >> Modified files: >> usr.sbin/mergemaster Makefile >> Removed files: >> usr.sbin/mergemaster mergemaster >> Log: >> ``mergemaster'' was repo-copied to ``mergemaster.sh'' as it's a >> shell script. >> >> Delete the original mergemaster and modify Makefile to install >> mergemaster.sh. > > Does it install it as ``mergmaster.sh''? If so then this is not a > good idea, > there have always been things that are shell scipts installed in *bin > that are > not called *.sh: > > gndrsh:rgrimes {1015}% file /usr/bin/* | grep -i shell > /usr/bin/apropos: Bourne shell script text ./gnu/usr.bin/man/apropos/apropos.sh > /usr/bin/c89: Bourne shell script text src/usr.bin/c89/c89.sh > /usr/bin/clear: Bourne shell script text ./usr.bin/tput/clear.sh etc.. Using .sh in src/ and then installing without the '.sh' is very prominent throughout teh source tree. Shoot, even sys.mk includes rules for installing foo.sh as foo and making it executable. I completely understood the commit message, and the silent majority seems to have as well. I like green bike sheds myself. > -- > Rod Grimes - KD7CAX @ CN85sl - (RWG25) > rgrimes@gndrsh.dnsmgr.net --- John Baldwin -- http://www.cslab.vt.edu/~jobaldwi/ PGP Key: http://www.cslab.vt.edu/~jobaldwi/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message