From owner-freebsd-current@FreeBSD.ORG Mon Apr 26 23:20:00 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CCC016A4CE; Mon, 26 Apr 2004 23:20:00 -0700 (PDT) Received: from alpha.siliconlandmark.com (alpha.siliconlandmark.com [209.69.98.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id B646C43D53; Mon, 26 Apr 2004 23:19:59 -0700 (PDT) (envelope-from andy@siliconlandmark.com) Received: from alpha.siliconlandmark.com (localhost [127.0.0.1]) i3R6Jsxn045249; Tue, 27 Apr 2004 02:19:54 -0400 (EDT) (envelope-from andy@siliconlandmark.com) Received: from localhost (andy@localhost)i3R6JslC045246; Tue, 27 Apr 2004 02:19:54 -0400 (EDT) (envelope-from andy@siliconlandmark.com) X-Authentication-Warning: alpha.siliconlandmark.com: andy owned process doing -bs Date: Tue, 27 Apr 2004 02:19:54 -0400 (EDT) From: Andre Guibert de Bruet To: sos@freebsd.org Message-ID: <20040427020355.Q21538@alpha.siliconlandmark.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-48885919-1083046794=:21538" X-MailScanner-Information: Please contact the ISP for more information X-MailScanner: Found to be clean cc: current@freebsd.org Subject: Recent ata-pci.c change breaks a7m266-d system (Was: Re:"setrootbyname failed" leads to "ffs_mountroot: can't find rootvp" on boot.) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2004 06:20:00 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-48885919-1083046794=:21538 Content-Type: TEXT/PLAIN; charset=US-ASCII On Sun, 25 Apr 2004, Andre Guibert de Bruet wrote: > (Sources pulled from CVS at Sun Apr 25 16:50:55 UTC 2004, an hour ago). > > Mounting root from ufs:/dev/ad4s1a > setrootbyname failed > ffs_mountroot: can't find rootvp > Root mount failed: 6 > > Manual root filesystem specification: > : Mount using filesystem > eg. ufs:da0s1a > ? List valid disk boot devices > Abort manual input > > mountroot> Okay, I found the commit that caused this problem. The following commit breaks my SMP desktop: http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/ata/ata-pci.c.diff?r1=1.80&r2=1.81&f=h Reverting the one line fixes things. I've attached a trivial one-line patch that reverts the change. Could this be committed? pciconf -vl: http://bling.properkernel.com/pciconf-vl.txt dmesg.boot: http://bling.properkernel.com/dmesg.boot.txt Regards, > Andre Guibert de Bruet | Enterprise Software Consultant > > Silicon Landmark, LLC. | http://siliconlandmark.com/ > --0-48885919-1083046794=:21538 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ata-pci.c.diff" Content-Transfer-Encoding: BASE64 Content-ID: <20040427021954.Y21538@alpha.siliconlandmark.com> Content-Description: Content-Disposition: attachment; filename="ata-pci.c.diff" SW5kZXg6IGF0YS1wY2kuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNT IGZpbGU6IC9ob21lL25jdnMvc3JjL3N5cy9kZXYvYXRhL2F0YS1wY2kuYyx2 DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuODENCmRpZmYgLXUgLXIxLjgxIGF0 YS1wY2kuYw0KLS0tIGF0YS1wY2kuYwkyNCBBcHIgMjAwNCAxNjozMjowNiAt MDAwMAkxLjgxDQorKysgYXRhLXBjaS5jCTI3IEFwciAyMDA0IDA1OjQyOjQz IC0wMDAwDQpAQCAtMTc3LDcgKzE3Nyw3IEBADQogICAgIGN0bHItPmxvY2tp bmcgPSBhdGFfcGNpX2xvY2tub29wOw0KIA0KICAgICBwcm9naWYgPSBwY2lf cmVhZF9jb25maWcoZGV2LCBQQ0lSX1BST0dJRiwgMSk7DQotICAgIGlmICgo cHJvZ2lmICYgMHg4MCkpDQorICAgIGlmICgocHJvZ2lmICYgMHg4NSkgPT0g MHg4MCkNCiAJcHJpc2VjID0gMTsNCiANCiAgICAgLyogaWYgbmVlZGVkIHRy eSB0byBlbmFibGUgYnVzbWFzdGVyaW5nICovDQo= --0-48885919-1083046794=:21538--