From owner-p4-projects@FreeBSD.ORG Wed Sep 12 22:46:32 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3360016A468; Wed, 12 Sep 2007 22:46:32 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ECF8316A420 for ; Wed, 12 Sep 2007 22:46:31 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.freebsd.org (Postfix) with ESMTP id 77C8113C478 for ; Wed, 12 Sep 2007 22:46:31 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so319674nfb for ; Wed, 12 Sep 2007 15:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=PvilHXEVwezJadLWTpMRSG08BiJ0O0HlHPKYbvshEQA=; b=G+0NS/vESmUkW37p1K585CMAhzNjQzR+fpxlF2TfDGEdZDGtvAn4Y/2D2wZJZ9b+GfRa3MRMjs2nO/OCTdI5jV1fQOCtBwjiiKUSKuZ/B9+2xCdg0QTslKaeNXjPnU6Gkm5ZuuVX7ksWTbxsZ3ZXg3Iy6CNkEAAaGJhS+mmbyUA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ML4exqG6OPc7JoVkSErAtlpvxzEaPZbFha9ajKw3dtAStE/+l6CBUWbZI7HefK7keRVeueVrUzD5eBAHW55WMjbD9UZCkkw3zUG0cGzCqTzZAasUB5IWolbx+os9bJrtL7eHJANNmUsVDFz/qn0tCGTgI8s+vQM7I3XDUYq9K+Q= Received: by 10.78.107.8 with SMTP id f8mr27385huc.1189637189620; Wed, 12 Sep 2007 15:46:29 -0700 (PDT) Received: by 10.78.120.9 with HTTP; Wed, 12 Sep 2007 15:46:29 -0700 (PDT) Message-ID: <3bbf2fe10709121546i375afaf5jc716f9f3609c35e9@mail.gmail.com> Date: Thu, 13 Sep 2007 00:46:29 +0200 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Pawel Jakub Dawidek" In-Reply-To: <20070912223833.GC4909@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200709120832.l8C8WLlm085731@repoman.freebsd.org> <20070912150017.GA3553@garage.freebsd.pl> <3bbf2fe10709121530h6d0681c4xa247fe7d31cb2c2e@mail.gmail.com> <20070912223833.GC4909@garage.freebsd.pl> X-Google-Sender-Auth: 865a447f10d9ed2d Cc: Kip Macy , Perforce Change Reviews , Kip Macy Subject: Re: PERFORCE change 126330 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2007 22:46:32 -0000 2007/9/13, Pawel Jakub Dawidek : > On Thu, Sep 13, 2007 at 12:30:26AM +0200, Attilio Rao wrote: > > 2007/9/12, Kip Macy : > > > On 9/12/07, Pawel Jakub Dawidek wrote: > > > > On Wed, Sep 12, 2007 at 08:32:21AM +0000, Kip Macy wrote: > > > > > http://perforce.freebsd.org/chv.cgi?CH=126330 > > > > > > > > > > Change 126330 by kmacy@kmacy_home:ethng on 2007/09/12 08:31:36 > > > > > > > > > > convert radix node head and route locks from mutexes to rwlocks > > > > [...] > > > > > rt->rt_flags |= RTF_LLINFO; > > > > > - callout_init_mtx(&la->la_timer, &rt->rt_mtx, > > > > > - CALLOUT_RETURNUNLOCKED); > > > > > + callout_init_rwlock(&la->la_timer, &rt->rt_lock, > > > > > + CALLOUT_RETURNUNLOCKED_RW); > > > > > > > > > > > > > Kip, don't add callout_init_rwlock() to the tree. I've > > > > callout_init_lock() implemented that operates on any lock type, just > > > > like condvar(9). > > > > > > point me to a diff > > > > I'm courious to know another thing instead. > > As like condvar() works, it is allowed to before release and later > > acquire the lock. > > This scheme let you acquire the lock again following the previous > > pattern for sx and rw locks (if for example you had a rwlock mantained > > in write mode you will acquire it in the same way). > > This is not applicable to callout, instead, as you have the lock > > 'blank', so with double-kind locks (like rw and sx) how do you lock > > it? > > Always write/exclusive. When thinking about it I was thinking to add an argument to functions in order to force from outside one of the two things (and maybe do some macro games with them). However write/exclusive one is reasonable for most usage. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein