From owner-svn-src-head@FreeBSD.ORG Tue Dec 7 11:31:59 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D9E91065695; Tue, 7 Dec 2010 11:31:59 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id A2EF08FC1C; Tue, 7 Dec 2010 11:31:58 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 72CEE45D8D; Tue, 7 Dec 2010 12:31:57 +0100 (CET) Received: from localhost (pdawidek.whl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 162CC45C9F; Tue, 7 Dec 2010 12:31:52 +0100 (CET) Date: Tue, 7 Dec 2010 12:31:52 +0100 From: Pawel Jakub Dawidek To: Ivan Voras Message-ID: <20101207113152.GG1700@garage.freebsd.pl> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> <20101206184453.GA1936@garage.freebsd.pl> <20101206192238.GB1936@garage.freebsd.pl> <20101206195327.GD1936@garage.freebsd.pl> <20101207102104.GD1700@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8bBEDOJVaa9YlTAt" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2010 11:31:59 -0000 --8bBEDOJVaa9YlTAt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 07, 2010 at 12:25:28PM +0100, Ivan Voras wrote: > On 7 December 2010 11:21, Pawel Jakub Dawidek wrote: >=20 > > PS. Do you know your change breaks all current ZFS installation if > > stripesize is defined for a provider? > > > > =A0 =A0 =A0 =A0# zpool create tank ada0 > > =A0 =A0 =A0 =A0(upgrade FreeBSD so that ada0 now reports 4kB stripesize) > > =A0 =A0 =A0 =A0# zpool import tank > > =A0 =A0 =A0 =A0cannot import 'tank': invalid vdev configuration >=20 > Actually I did test the patch and, similar to the Solaris people, > found that ZFS records ashift in metadata and uses the recorded one > instead of hardcoded / detected one. What you found here really > shouldn't happen. Are you sure only stripesize was increased in your > case, not sectorsize? if (pp->stripesize > pp->sectorsize) *ashift =3D highbit(MIN(pp->stripesize, SPA_MAXBLOCKSIZE)) - 1; else *ashift =3D highbit(MAX(pp->sectorsize, SPA_MINBLOCKSIZE)) - 1; If stripesize will start to be 4096, the ashift will change. Not sure what you test was, but it only works the other way around - create pool with 4kB ashift and import it when ashift is 512 bytes. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --8bBEDOJVaa9YlTAt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkz+GygACgkQForvXbEpPzQjQwCeM42rF9i0vP9vc2hKXvcZd2fH dGAAoOUriQNLSFoCXzqrQYvikHqhM6l+ =zEIN -----END PGP SIGNATURE----- --8bBEDOJVaa9YlTAt--