From owner-freebsd-current@FreeBSD.ORG Wed Jun 29 13:08:07 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 21DC2106564A for ; Wed, 29 Jun 2011 13:08:07 +0000 (UTC) (envelope-from onwahe@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 014148FC16 for ; Wed, 29 Jun 2011 13:08:06 +0000 (UTC) Received: by pvg11 with SMTP id 11so1070853pvg.13 for ; Wed, 29 Jun 2011 06:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=x2+yk1k3yl2sdT70QqZP5+G7Xs262cyID9qRi0EaqY8=; b=lF7YOz9YAcm/ygCt4Z55oDgxx5iF9Iwmin3O0vm+S4SS41WSqTpCmvwxqna+jg/0LL hBM+dBS0/Sj/835rhXDDjCz7V1FxJNc//EUaTBcj5VsP/VgAlUXrq7oi4meXam415a+P gQX0go2mQRCrbQvclHh3OFpIU+/GLvsF7vJEA= MIME-Version: 1.0 Received: by 10.142.61.3 with SMTP id j3mr429876wfa.102.1309351412386; Wed, 29 Jun 2011 05:43:32 -0700 (PDT) Received: by 10.142.239.4 with HTTP; Wed, 29 Jun 2011 05:43:32 -0700 (PDT) Date: Wed, 29 Jun 2011 14:43:32 +0200 Message-ID: From: Svatopluk Kraus To: freebsd-current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: a question about message X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2011 13:08:07 -0000 Hi, I've got message from ifa_del_loopback_route() called from rip_ctlinput(). Is IFA_RTSELF flag consistent with ifa_add_loopback_route() and ifa_del_loopback_route() calls? I think that rip_ctlinput() in sys/netinet/raw_ip.c should be patched to do a check that IFA_RTSELF flag is set before ifa_del_loopback_route() is called. The proposed check is done in in_scrubprefix() in sys/netinet/in.c. Or exists some reason that it is not a good idea? I've got the message as nobody calls ifa_add_loopback_route() before ifa_del_loopback_route(). Svata