From owner-freebsd-bugs@FreeBSD.ORG Sun Aug 17 06:57:24 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 95C7CF08 for ; Sun, 17 Aug 2014 06:57:24 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 642B020E5 for ; Sun, 17 Aug 2014 06:57:24 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s7H6vOJI010651 for ; Sun, 17 Aug 2014 06:57:24 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 192734] New: [build] [patch] clang uses DPADD for sources (should use DPSRCS instead); fails checkdpadd Date: Sun, 17 Aug 2014 06:57:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: yaneurabeya@gmail.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Aug 2014 06:57:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192734 Bug ID: 192734 Summary: [build] [patch] clang uses DPADD for sources (should use DPSRCS instead); fails checkdpadd Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: conf Assignee: freebsd-bugs@FreeBSD.org Reporter: yaneurabeya@gmail.com As reported by bde, the clang portion of the build system uses DPADD to specify source files, which makes "make checkdpadd" whine like so: ===> lib/clang/libclanganalysis (checkdpadd) /usr/src/lib/clang/libclanganalysis DPADD -> AttrList.inc.h Attrs.inc.h CommentCommandList.inc.h CommentNodes.inc.h DeclNodes.inc.h DiagnosticAnalysisKinds.inc.h DiagnosticCommonKinds.inc.h StmtNodes.inc.h LDADD -> DPADD should only be used by libraries. If I change DPADD to DPSRCS, make checkdpadd passes. I verified that the dependency information was correct and it compiles, but I haven't verified that everything works yet. Here's the patch: % git diff clang.build.mk diff --git a/lib/clang/clang.build.mk b/lib/clang/clang.build.mk index 5465272..3b30fe7 100644 --- a/lib/clang/clang.build.mk +++ b/lib/clang/clang.build.mk @@ -237,5 +237,5 @@ Checkers.inc.h: ${CLANG_SRCS}/lib/StaticAnalyzer/Checkers/Checkers.td .endfor SRCS+= ${TGHDRS:C/$/.inc.h/} -DPADD+= ${TGHDRS:C/$/.inc.h/} +DPSRCS+= ${TGHDRS:C/$/.inc.h/} CLEANFILES+= ${TGHDRS:C/$/.inc.h/} ${TGHDRS:C/$/.inc.d/} -- You are receiving this mail because: You are the assignee for the bug.