From owner-cvs-src@FreeBSD.ORG Thu May 22 17:19:23 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 33ABA10656C0; Thu, 22 May 2008 17:19:23 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id D02858FC1B; Thu, 22 May 2008 17:19:22 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.local ([192.168.254.200]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id m4MHJEOt054098; Thu, 22 May 2008 11:19:15 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4835AB12.9060306@samsco.org> Date: Thu, 22 May 2008 11:19:14 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 MIME-Version: 1.0 To: Maxim Sobolev References: <200805221440.m4MEe32W039559@repoman.freebsd.org> <4835A619.3010502@FreeBSD.org> <4835A71E.3030703@freebsd.org> <4835AA65.6070708@FreeBSD.org> In-Reply-To: <4835AA65.6070708@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=3.8 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, Sam Leffler , Ed Schouten , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/share/man/man3 Makefile queue.3 src/sys/sys queue.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2008 17:19:23 -0000 Maxim Sobolev wrote: > Sam Leffler wrote: >> Maxim Sobolev wrote: >>> Ed Schouten wrote: >>>> The OpenBSD version of SLIST_REMOVE_NEXT() needs a reference to >>>> the list >>>> head, even though it is unused. >>> >>> I don't think it's necessary. sys/queue.h API is not supposed to be >>> portable across different operating systems. The need to pass list >>> head around may impede macro usefulness. >> Gratuitous differences impede porting. If it's not a big deal then >> maintain compatibility. We already have stupid differences in various >> areas that must be papered over when code is brokered between systems. > > This is local use convenience vs. easy of porting tradeoff. On one hand > API is used heavily in the kernel on the other I don't think we have lot > of kernel code being ported from OpenBSD nowadays. That's pretty presumptuous to say, and untrue. > So that local use > convinience should win a big. It'll be more convenient to follow what Ed is comfortable with and what he's already done than to nit pick such a minor detail =-) Scott