Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 May 2023 14:34:18 +0800
From:      Li-Wen Hsu <lwhsu@freebsd.org>
To:        =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org,  dev-commits-src-main@freebsd.org
Subject:   Re: git: 4849767cb16a - main - md5: Improve compatibility.
Message-ID:  <CAKBkRUyDk58Sq8E0vxhpLy7fdfEamJYNF9Oh8a1axZJB5yuTuA@mail.gmail.com>
In-Reply-To: <202305080805.34885P8c017963@gitrepo.freebsd.org>
References:  <202305080805.34885P8c017963@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 8, 2023 at 4:05=E2=80=AFPM Dag-Erling Sm=C3=B8rgrav <des@freebs=
d.org> wrote:
>
> The branch main has been updated by des:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D4849767cb16a4dbd4d1b923db2=
5d34029c09e7b0
>
> commit 4849767cb16a4dbd4d1b923db25d34029c09e7b0
> Author:     Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org>
> AuthorDate: 2023-05-08 06:56:09 +0000
> Commit:     Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org>
> CommitDate: 2023-05-08 06:56:22 +0000
>
>     md5: Improve compatibility.
>
>     * Overhaul the GNU compatibility mode to more closely emulate what th=
e GNU tools do.
>
>     * Add a Perl compatibility mode which emulates the shasum tool that s=
hips with Perl.  This is currently not installed.
>
>     * Overhaul the tests.
>
>     Sponsored by:   Klara, Inc.
>     Reviewed by:    kevans
>     Differential Revision:  https://reviews.freebsd.org/D39446

gcc12 reports:

/workspace/src/sbin/md5/md5.c: In function 'MDInput':
/workspace/src/sbin/md5/md5.c:737:17: error: comparison of unsigned
expression in '< 0' is always false [-Werror=3Dtype-limits]
  737 |         if (len < 0) {
      |                 ^

(From https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc12_build/950/console=
 )

Not sure if this can be changed to `len <=3D 0`, or just remove this
part. Can you check it? Thanks!

Best,
Li-Wen



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUyDk58Sq8E0vxhpLy7fdfEamJYNF9Oh8a1axZJB5yuTuA>