From owner-freebsd-arch@FreeBSD.ORG Wed Jul 7 15:35:44 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CB38106566B for ; Wed, 7 Jul 2010 15:35:44 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 1BC818FC1B for ; Wed, 7 Jul 2010 15:35:43 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2D22F.dip.t-dialin.net [217.226.210.47]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id CEC8684407A; Wed, 7 Jul 2010 17:35:39 +0200 (CEST) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id AB67650F5; Wed, 7 Jul 2010 17:35:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1278516936; bh=C0plNL+GUuf2TmTbQZks+9/fJU71zXDtMWX3EGv6bJg=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=a+leRgJlQ0egjyXc5Ax1HNkRkLVoGUvS2vIlVM2+GHcLgGpi//NF1hCOobwID7WQE wa2BVsbJxffncrXmYHnuJwbMVZW4v+NV7FWuXLvq3sTqH7u70FIKKHL9jw3ZgZxLK9 Ae3pQ5TI/ilGj3aXXU8zdCbD/01skqa+SjDod3XfV6KHCAQHCBC8ytIrizy7FixSp8 kxDI74xc5pQnlsTY03Vst+eStonbYOkUpBzUreWaDGc33HaP76zUP/NLQbpYcYB5BU 07QF+H2sp/fTv4ZcuYYKWARnL0/1PPlMkHIRtTAslcHVoSSa+DcRt1lC+D1LCKBSPu UrL6MTJ7pURLw== Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id o67FZaZm047625; Wed, 7 Jul 2010 17:35:36 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 07 Jul 2010 17:35:36 +0200 Message-ID: <20100707173536.14541wa0krsmogcg@webmail.leidinger.net> Date: Wed, 07 Jul 2010 17:35:36 +0200 From: Alexander Leidinger To: "M. Warner Losh" References: <20100706.174919.29649800801850.imp@bsdimp.com> <20100707145634.13925yt8ztdkz4is@webmail.leidinger.net> <20100707.084213.353672579433544368.imp@bsdimp.com> In-Reply-To: <20100707.084213.353672579433544368.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: CEC8684407A.A6D7C X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.1, required 6, autolearn=disabled, ALL_TRUSTED -1.00, DKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1279121741.3705@q6q/5kc8PwIOR6NRTXNZIw X-EBL-Spam-Status: No Cc: arch@FreeBSD.org Subject: Re: ObsoleteFiles and TARGET_ARCH X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2010 15:35:44 -0000 Quoting "M. Warner Losh" (from Wed, 07 Jul 2010 08:42:13 -0600 (MDT)): > In message: <20100707145634.13925yt8ztdkz4is@webmail.leidinger.net> > Alexander Leidinger writes: > : Quoting "M. Warner Losh" (from Tue, 06 Jul 2010 > : 17:49:19 -0600 (MDT)): > : > : > I'm wondering... > : > > : > Why do we use TARGET_ARCH so much inside of ObsoleteFiles? It seems > : > like it should be used only when we obsolete files on some > : > architectures, but retain them on others. Instead, it seems to be > : > used to obsolete files that normally exist on a specific > : > architecture. This seems backwards. > : > : As the person who wrote this initially: > : > : The goal was to only delete stuff which was not available anymore on > : one architecture but where still available on others (as in the > : 20040130 entry, IIRC at this time the rename was specific to sparc64 > : and other architectures still had this lib). If it is not used like > : this, it is a bug. > > Then we have a lot of bugs. About 45 of the 49 instances are > definitely wrong from my quick inspection. If those 45 instances are covering just one or two files, I agree. If those instances cover a huge number of files, it should be investigated if it makes a speed difference on architectures where those files never where. I do not expect it would make a significant speed difference in this case, but as I haven't measured it... > : > Also, we need to change this, but I don't (yet) define a > : > TARGET_CPUARCH. > : > > : > Also, why is this TARGET_ARCH and not MACHINE_ARCH? That suggests > : > we're invoking it wrong if this is "needed" for the cross build case > : > to "work". > : > : The goal was to have something which can be used like "make > : DESTDIR=/... XXX=arch_of_dest delete-old" where DESTDIR is either a > : remote FS for a system of architecture as specified by XXX, or a local > : mount of something with the same properties like in the remote FS > : case. Without the XXX on the command line it shall behave like the > : architecture is the same as the current system. If TARGET_ARCH is not > : the correct XXX in the sense as described before, feel free to change > : it to something better. I think I used TARGET_ARCH after looking at > : what make universe is/was doing. > > The TARGET_ARCH=foo on the command line is correct. However, the > environment that these commands operate in should be the target one, > not the host one. ru@ appears to have changed MACHINE_ARCH to I'm not sure I understand what you want to tell (due to lack of enough knowledge what those *_ARCH are supposed to do). As long as your description matches the following use case, I'm ok with any change you want to make in this regard: Assume your system is running with an amd64 world and kernel, and you have a world for FOO128 available at /import/foobar which is at the same revision than what you have in /usr/src. You want to run "make DESTDIR=/import/foobar XXX=FOO128 delete-old" to delete the old files for FOO128 in /import/foobar. Bye, Alexander. > TARGET_ARCH to, according to the comments, work in a cross-build > world. However, I think he fixed that bug incorrectly, so I'll try to > fix it properly as part of my general cleanup of TARGET_ARCH abuses in > the tree. > > Warner > > -- First law of debate: Never argue with a fool. People might not know the difference. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137