Date: Mon, 15 Aug 2016 01:32:49 +0300 From: Lev Serebryakov <lev@FreeBSD.org> To: "Andrey V. Elsukov" <ae@FreeBSD.org>, freebsd-ipfw@freebsd.org Subject: Re: Named states in ipfw (and old rulesets) Message-ID: <516433114.20160815013243@serebryakov.spb.ru> In-Reply-To: <2126139e-9c11-a55c-7573-8b4d3869bf87@FreeBSD.org> References: <1812167147.20160814202008@serebryakov.spb.ru> <1211733990.20160814202656@serebryakov.spb.ru> <2126139e-9c11-a55c-7573-8b4d3869bf87@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hello Andrey, Sunday, August 14, 2016, 9:01:15 PM, you wrote: I have very formal objection against "any unknown token after *-state is state name": it hides mistakes and typos very well. I've been bitten by this right now. New patch uses "defer-action", but old "record-state skip-action" passes without error, because "skip-action" is valid state name! Please, change this to some prefix to state name (:name, @name or something like this) or to "state-action(name)" format. It will be much better: less error-prone and will work without ugly warnings on old rulesets. -- Best regards, Lev mailto:lev@FreeBSD.org [-- Attachment #2 --] -----BEGIN PGP MESSAGE----- Version: GnuPG v2.0.22 (MingW32) iQJ8BAEBCgBmBQJXsPGRXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGOTZEMUNBMEI1RjQzMThCNjc0QjMzMEFF QUIwM0M1OEJGREM0NzhGAAoJEOqwPFi/3EePsl4QAK3T81Fs87tzrpbwxW+PRE4o CV7ZYYIiAiSNFfPdGiHNTXJnVWt6PsxFTVEshe1nxp/9W5SsvKge4XbtTr3H0hXw Va+xqnUrCrgOpA439HzaF4iM7PivqIujKUiQIX5oub7s2M+MtC1kWfa98TPSxH3N Wu3DFy8kre2g06gl2pKNXHYOIbDoJUH/7Z0lMVJhYCJZPRxpXzJZep1EILYTGPES Rgv4XCA12JNkjWld42VgCHLla2tbiyiNW3PRtIr4T56lAGB37neQtHHA+YI/UJV1 McNBBcGwuNf/c+DguQzWnkEGfLXp32CmUY3DiJ1yY4X5GDHwMmoPS7pSNiegoyXI 7B6r1pyJnoF61nSK+uvtSG4ZO8tFdz9VsbzFdCiaEJKz5NOabD5tVUI9BifM/S+X 3aFllxgV4450cy0ZEPdDpoxnFhyb+VVZEwzz8txuXEz293fIAy4TeSOg7aUHP3IL iCnQIaps9kOxIkmZKJdtLEI+QbQwIsfKg1Loi+kE2PG+rHs+JUrvlaDKFLgj/OlV /OWML7rII6hYZ5+4IM/zGPOnx5OdJsZJCMeFK+JDKQEh7Dyoygo48j0mBGgQmAGK Nscjjy/erVpeK4O9y3c7nlw88KWqwE/sNWco/Ea6gWLGrV+uYuVFks1oh4QKNXoF 4ccMLG1b1CSm9M/Wp66t =+tjG -----END PGP MESSAGE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?516433114.20160815013243>