Date: Wed, 06 Nov 2013 11:21:27 -0500 From: Kris Moore <kris@pcbsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Kris Moore <kmoore@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332589 - in head/sysutils: . grub2-bhyve Message-ID: <527A6C87.8060308@pcbsd.org> In-Reply-To: <20131106062901.GA60770@FreeBSD.org> References: <201311030511.rA35BxT7011202@svn.freebsd.org> <20131106062901.GA60770@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/06/13 01:29, Alexey Dokuchaev wrote: > On Sun, Nov 03, 2013 at 05:11:59AM +0000, Kris Moore wrote: >> New Revision: 332589 >> URL: http://svnweb.freebsd.org/changeset/ports/332589 >> >> +MASTER_SITES= http://github.com/${GH_ACCOUNT}/${PORTNAME}/archive/v${DISTVERSION}.tar.gz?dummy=/ > Why is this (ugly) line needed in presence of USE_GITHUB? Took another look, needed to set GH_TAGNAME to "v0.2" not "0.2". Fixed >> +USE_GCC= 4.7 > Why USE_GCC=yes (or even any) cannot be used? Even more, what's exactly > wrong with Clang that port cannot be patched to support any compiler? You'll have to ask Peter upstream, the GitHub notes, plus Peter told me it needs GCC 4.7 specifically, don't know the underlying reason. >> +USE_GMAKE= yes > USE_GMAKE is deprecated, you should've added "gmake" to USES instead. Will fix, I just coped this from sysutils/grub2 and it still uses that line :P > >> +ONLY_FOR_ARCHS= amd64 > Misplaced line. It is not build-environment related; better reads just > after COMMENT or LICENSE. > Are you sure? Portlint complains when I put it above BUILD_DEPS or in the LICENSE / COMMENT section :( >> +MAKE_JOBS_UNSAFE= yes > I will take a look how to make it -jX safe. Cool > >> +CONFIGURE_ARGS= --with-platform=emu CC=gcc47 LEX=${LOCALBASE}/bin/flex --enable-grub-mount=no --enable-grub-mkfont=no > Very long line. Makefiles support line wrapping via backslash (\). Fixed > >> +WRKSRC= ${WRKDIR}/${PORTNAME}-${DISTVERSION} > If you would've used GH_* knobs correctly, you would not have to set WRKSRC. Fixed > >> +do-configure: >> + @ cd ${WRKSRC}/ && ./configure ${CONFIGURE_ARGS} > What's wrong with default do-configure target? When I run without custom do-configure this is what I get: ===> Configuring for grub2-bhyve-0.2 ===> FreeBSD 10 autotools fix applied to /usr/ports/sysutils/grub2-bhyve/work/grub2-bhyve-0.2/aclocal.m4 ===> FreeBSD 10 autotools fix applied to /usr/ports/sysutils/grub2-bhyve/work/grub2-bhyve-0.2/build-aux/config.rpath ===> FreeBSD 10 autotools fix applied to /usr/ports/sysutils/grub2-bhyve/work/grub2-bhyve-0.2/acinclude.m4 ===> FreeBSD 10 autotools fix applied to /usr/ports/sysutils/grub2-bhyve/work/grub2-bhyve-0.2/configure ===> Building for grub2-bhyve-0.2 gmake[1]: Entering directory `/usr/ports/sysutils/grub2-bhyve/work/grub2-bhyve-0.2' gmake[1]: Makefile: No such file or directory gmake[1]: *** No rule to make target `Makefile'. Stop. gmake[1]: Leaving directory `/usr/ports/sysutils/grub2-bhyve/work/grub2-bhyve-0.2' *** Error code 1 Is there a way to disable all the autotools fix? > >> +do-build: >> + @ cd ${WRKSRC}/ && ${GMAKE} > What's wrong with default do-build target? Also, referencing GMAKE here is > wrong, it should be MAKE_CMD. This will be removed, was from testing. >> +do-install: >> + @${INSTALL_PROGRAM} ${WRKSRC}/grub-core/grub-emu ${STAGEDIR}${LOCALBASE}/sbin/grub-bhyve > We do not mute installation comments, it pessimises debugging and confuses > user that nothing was installed at all. Unmuted > ./danfe > > P.S. With all due respect Kris, don't get me wrong, but quantity of quite > a few common mistakes in this commit makes me wondering if you're subscribed > to svn-ports-* ML, like you probably should. Sorry, I don't do many of these now-a-days, plus portlint was happy, so away it went :) I'll try to keep an closer eye on svn-ports in the future. -- Kris Moore PC-BSD Software iXsystems
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?527A6C87.8060308>