From owner-freebsd-current Tue Apr 4 0: 3:32 2000 Delivered-To: freebsd-current@freebsd.org Received: from peedub.muc.de (peedub.muc.de [193.149.49.109]) by hub.freebsd.org (Postfix) with ESMTP id 7BC1237B512 for ; Tue, 4 Apr 2000 00:03:29 -0700 (PDT) (envelope-from garyj@peedub.muc.de) Received: from peedub.muc.de (localhost [127.0.0.1]) by peedub.muc.de (8.9.3/8.6.9) with ESMTP id IAA25879; Tue, 4 Apr 2000 08:59:41 +0200 (CEST) Message-Id: <200004040659.IAA25879@peedub.muc.de> X-Mailer: exmh version 2.1.0 09/18/1999 To: Peter Wemm Cc: Bruce Evans , freebsd-current@FreeBSD.ORG Subject: Re: MLEN and crashes Reply-To: Gary Jennejohn In-reply-to: Your message of "Tue, 04 Apr 2000 08:25:51 +0200." <20000404062505.0BE021CD7@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 04 Apr 2000 08:59:41 +0200 From: Gary Jennejohn Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Peter Wemm writes: >Gary Jennejohn wrote: >> Bruce Evans writes: >> >On Mon, 3 Apr 2000, Gary Jennejohn wrote: >> > >> >> Bruce Evans writes: >> >> >On Sun, 2 Apr 2000, Gary Jennejohn wrote: >> >> >> I think we should nuke csu_hdr since it's not used anywhere. Is that >> >> >> what you really mean ? >> >> > >> >> >Yes. I'm trying the following patch. Only tested at compile time. >> >> > >> >> [patch snipped] >> >> >> >> Thank you, Bruce ! This is pretty much the same patch I tested. >> >> >> >> So, should I commit it ? >> > >> >If you have tested it :-). >> > >> >> I'm running with the change right now. No problems. > >I would prefer that we did this: > >#define MAX_LEN (min(128, MLEN)) > >or something like that. This should stop Bad Things happening if >somebody recompiles with MLEN set specifically to 128 (and is an ideal >MFC candidate for 4.x for when people set MLEN to 256 over there). > This is a pretty good idea, too. But I already deleted csu_hdr in -current. It would be easy enough to back out the change if there's consensus. --- Gary Jennejohn / garyj@muc.de gj@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message