From owner-freebsd-fs@FreeBSD.ORG  Thu Nov 11 20:23:11 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EACC0106566C;
	Thu, 11 Nov 2010 20:23:11 +0000 (UTC) (envelope-from lists@mawer.org)
Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com
	[209.85.212.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 95AE58FC19;
	Thu, 11 Nov 2010 20:23:11 +0000 (UTC)
Received: by vws20 with SMTP id 20so623653vws.13
	for <multiple recipients>; Thu, 11 Nov 2010 12:23:10 -0800 (PST)
MIME-Version: 1.0
Received: by 10.229.236.196 with SMTP id kl4mr1110283qcb.109.1289505467057;
	Thu, 11 Nov 2010 11:57:47 -0800 (PST)
Received: by 10.229.91.66 with HTTP; Thu, 11 Nov 2010 11:57:46 -0800 (PST)
In-Reply-To: <AANLkTi=KtGJjhEzRnQN78koFQqvtFC1c+qVfunUdae+w@mail.gmail.com>
References: <ib8qda$nat$1@dough.gmane.org> <201011081004.59640.jhb@freebsd.org>
	<20101108151028.GI2392@deviant.kiev.zoral.com.ua>
	<AANLkTi=KtGJjhEzRnQN78koFQqvtFC1c+qVfunUdae+w@mail.gmail.com>
Date: Fri, 12 Nov 2010 06:57:46 +1100
Message-ID: <AANLkTikpOs9TzjqV3TUZCTYW9zmzvNr2FtYaDWhMY+=R@mail.gmail.com>
From: Antony Mawer <lists@mawer.org>
To: Ivan Voras <ivoras@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-fs@freebsd.org
Subject: Re: The state of Giant lock in the file systems?
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Nov 2010 20:23:12 -0000

On Tue, Nov 9, 2010 at 2:28 AM, Ivan Voras <ivoras@freebsd.org> wrote:
> On 8 November 2010 16:10, Kostik Belousov <kostikbel@gmail.com> wrote:
>
>> I already claimed several times that I will remove VFS_LOCK_GIANT
>> after smbfs is locked. Patch for removal is sitting in my repository
>> for almost a year.
>
> Ok, I've made a little table here:
>
> http://wiki.freebsd.org/MPSAFE_VFS

FYI - NWFS is still functional in 8.x (there are some minor but
annoying bugs, e.g. the root node path resolution occasionally trips
over itself causing the mount point to become inaccessible, but that's
been there since 4.x days), and I am happy to test any locking changes
to it.

>From memory NWFS and SMBFS share similar locking strategies so what
gets done to one typically gets applied to the other. This got hit
early in the 6.0 beta series where SMBFS had VFS locking changes which
hadn't been applied to NWFS. On that occasion we were able to work
with truckman@ to isolate the problem and get the right locking
changes made in time for 6.0's release.

On the SMBFS front, it's largely unmaintained as well (sadly) -- there
are patches to add Unicode support to SMBFS which have been floating
around since 2005, but so far they have (to my knowledge) never seen
any reviews:

http://people.freebsd.org/~imura/kiconv/

SMBFS and NWFS both share a lot of similar designs in terms of their
FreeBSD implementations due to being both implemented by the same
developer (bp@).

--Antony