From owner-svn-src-all@FreeBSD.ORG Fri May 22 19:13:01 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68FE8106566B; Fri, 22 May 2009 19:13:01 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 38EA28FC1C; Fri, 22 May 2009 19:13:01 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id CCFB246B6C; Fri, 22 May 2009 15:13:00 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id A32A98A025; Fri, 22 May 2009 15:12:59 -0400 (EDT) From: John Baldwin To: Kip Macy Date: Fri, 22 May 2009 15:07:39 -0400 User-Agent: KMail/1.9.7 References: <200905221754.n4MHs3cr014003@svn.freebsd.org> In-Reply-To: <200905221754.n4MHs3cr014003@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905221507.39476.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 22 May 2009 15:12:59 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r192590 - stable/7/sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2009 19:13:02 -0000 On Friday 22 May 2009 1:54:03 pm Kip Macy wrote: > Author: kmacy > Date: Fri May 22 17:54:02 2009 > New Revision: 192590 > URL: http://svn.freebsd.org/changeset/base/192590 > > Log: > some ports erroneously use the existence of AT_FDCWD to check for > the availability of the *at system calls so s/AT_FDCWD/AT_FDCWD_notyet/g > > Reported by: Dimitry Andric I wonder if it wouldn't be appropriate to just remove the dirfd bits entirely from 7.x for now. I.e. remove NDINIT_AT(), AT_FDCWD_notyet, the 'dirfd' member from the structure, the 'dirfd' parameter from NDINIT_ALL(), etc. ZFS only really needed NDINIT_ATVP(), yes? > Modified: > stable/7/sys/sys/fcntl.h > stable/7/sys/sys/namei.h > > Modified: stable/7/sys/sys/fcntl.h > ============================================================================== > --- stable/7/sys/sys/fcntl.h Fri May 22 16:46:01 2009 (r192589) > +++ stable/7/sys/sys/fcntl.h Fri May 22 17:54:02 2009 (r192590) > @@ -110,7 +110,7 @@ typedef __pid_t pid_t; > * to determine the target of relative file paths in the openat() and > * similar syscalls. > */ > -#define AT_FDCWD -100 > +#define AT_FDCWD_notyet -100 > > /* Defined by POSIX 1003.1; BSD default, but must be distinct from O_RDONLY. */ > #define O_NOCTTY 0x8000 /* don't assign controlling terminal */ > > Modified: stable/7/sys/sys/namei.h > ============================================================================== > --- stable/7/sys/sys/namei.h Fri May 22 16:46:01 2009 (r192589) > +++ stable/7/sys/sys/namei.h Fri May 22 17:54:02 2009 (r192590) > @@ -154,11 +154,11 @@ struct nameidata { > * Initialization of a nameidata structure. > */ > #define NDINIT(ndp, op, flags, segflg, namep, td) \ > - NDINIT_ALL(ndp, op, flags, segflg, namep, AT_FDCWD, NULL, td) > + NDINIT_ALL(ndp, op, flags, segflg, namep, AT_FDCWD_notyet, NULL, td) > #define NDINIT_AT(ndp, op, flags, segflg, namep, dirfd, td) \ > NDINIT_ALL(ndp, op, flags, segflg, namep, dirfd, NULL, td) > #define NDINIT_ATVP(ndp, op, flags, segflg, namep, vp, td) \ > - NDINIT_ALL(ndp, op, flags, segflg, namep, AT_FDCWD, vp, td) > + NDINIT_ALL(ndp, op, flags, segflg, namep, AT_FDCWD_notyet, vp, td) > > static __inline void > NDINIT_ALL(struct nameidata *ndp, > -- John Baldwin